Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xkcd: address py/mixed-returns CodeQL alert #2511

Merged
merged 1 commit into from
Sep 28, 2023
Merged

xkcd: address py/mixed-returns CodeQL alert #2511

merged 1 commit into from
Sep 28, 2023

Conversation

dgw
Copy link
Member

@dgw dgw commented Sep 27, 2023

Description

I started this branch intending to fixup several other alerts, but realized that most of them were of the same type we already decided to dismiss (no one really cares about the return value of a plugin callable).

However, xkcd has a real function that was flagged by this rule, so I chose to still fix it even though it means opening a dinky +1 pull request. But I won't bother milestoning this until it's merged, so it doesn't affect our release timelines in any way.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make lint and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label Sep 27, 2023
@dgw dgw requested a review from a team September 27, 2023 16:18
@dgw dgw merged commit 03dd79b into master Sep 28, 2023
13 checks passed
@dgw dgw deleted the py/mixed-returns branch September 28, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants