xkcd: address py/mixed-returns CodeQL alert #2511
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I started this branch intending to fixup several other alerts, but realized that most of them were of the same type we already decided to dismiss (no one really cares about the return value of a plugin callable).
However,
xkcd
has a real function that was flagged by this rule, so I chose to still fix it even though it means opening a dinky +1 pull request. But I won't bother milestoning this until it's merged, so it doesn't affect our release timelines in any way.Checklist
make qa
(runsmake lint
andmake test
)