calc: gracefully handle ExpressionEvaluator.Error
#2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might consider making this exception a standalone class, for less wacky-looking error handling in this and other consumers of the `tools.calculation` submodule. Doing `except a_function.Subclass` feels weird and wrong.
dgw
force-pushed
the
calc-error-handler
branch
from
855cc98
to
a12e799
Compare
Exirel
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced fallthrough to Sopel's bot-level "Unexpected Error" handler with a more graceful presentation of the error message.
Checklist
make qa(runsmake lintandmake test)Notes
We might consider making this exception a standalone class, for less wacky-looking error handling in this and other consumers of the
tools.calculationsubmodule. Doingexcept a_function.Subclassfeels weird and wrong.