-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build, meta: drop Python 3.7 support, checks, and CI job #2500
Commits on Aug 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 45ce17c - Browse repository at this point
Copy the full SHA 45ce17cView commit details -
docs/docstrings: replace links to Python 3.7 docs w/links to 3.11 pages
Linking to just `/3/` is admittedly risky, because item/anchor locations can change across Python versions. Bumping the links from 3.7 to 3.11 gives us a few more years of not needing to touch them.
Configuration menu - View commit details
-
Copy full SHA for 4d2f19c - Browse repository at this point
Copy the full SHA 4d2f19cView commit details -
sopel:
importlib_metadata
backport -> stdlibimportlib.metadata
Can't drop the `importlib_metadata` requirement yet, though. We use some stuff elsewhere that isn't stable in stdlib until py3.10.
Configuration menu - View commit details
-
Copy full SHA for a903e5d - Browse repository at this point
Copy the full SHA a903e5dView commit details -
plugins.handlers: use
TypedDict
forget_meta_description()
returnsPlayed with using intentionally wrong types in the definition of a `PluginMetaDescription` and running `mypy` against it, but didn't see any (new) errors flagged over that. Maybe I did it wrong, but it took enough work shuffling docstrings around that I'm committing this anyway.
Configuration menu - View commit details
-
Copy full SHA for de572cd - Browse repository at this point
Copy the full SHA de572cdView commit details -
announce: simplify chunking loop to use walrus operator
The test covering `_chunks()` still passes, so hooray!
Configuration menu - View commit details
-
Copy full SHA for 451a36e - Browse repository at this point
Copy the full SHA 451a36eView commit details -
irc.isupport: simplify
OrderedDict
->dict
Regular `dict` is promised to maintain insertion order as of Python 3.7 (which means this could have been done sooner, but it got forgotten, so we're doing it at the point of dropping Python <3.8 instead).
Configuration menu - View commit details
-
Copy full SHA for 8ad45b7 - Browse repository at this point
Copy the full SHA 8ad45b7View commit details
Commits on Aug 3, 2023
-
plugins.rules: clean up forgotten py2 list-copy holdover
Not doing exactly as the comment says because different Rule subclasses pass aliases as either tuple or list depending on how whoever wrote the subclass was feeling that day. Instead, let's simplify the code to do everything in one step, and unpack the `aliases` iterable so its type won't even matter. Co-authored-by: SnoopJ <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2bcddff - Browse repository at this point
Copy the full SHA 2bcddffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 314c8a2 - Browse repository at this point
Copy the full SHA 314c8a2View commit details -
plugins.handlers: use stdlib for
EntryPointPlugin.get_version()
`importlib.metadata` officially starts existing in Python 3.8, and we are removing support for Python 3.7 before Sopel 8's stable release. That means we can use the stdlib approach here to get the version string for an entry-point plugin, and drop another `import importlib_metadata`. I can't wait for Python 3.9's EOL... We can remove `importlib_metadata` completely then.
Configuration menu - View commit details
-
Copy full SHA for 57b692c - Browse repository at this point
Copy the full SHA 57b692cView commit details -
tld: be more specific about JSONDecodeError instead of ValueError
As of Python 3.5, we can do this. It's overdue.
Configuration menu - View commit details
-
Copy full SHA for c743861 - Browse repository at this point
Copy the full SHA c743861View commit details -
test: update
plugins
tests to use importlib.metadata directlyimportlib.metadata.EntryPoint *shouldn't* differ from Python 3.8 onward, unless there's something missing from the documentation. If this breaks stuff on older Python releases (I'm on 3.10 locally), we will defer this change until we drop 3.9 as planned per the code comments.
1Configuration menu - View commit details
-
Copy full SHA for 2a6d146 - Browse repository at this point
Copy the full SHA 2a6d146View commit details