Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meetbot: remove in favor of external package #2477

Merged
merged 1 commit into from
Jul 13, 2023
Merged

meetbot: remove in favor of external package #2477

merged 1 commit into from
Jul 13, 2023

Conversation

dgw
Copy link
Member

@dgw dgw commented Jun 17, 2023

Description

Tin. Why?

<+xrl> I'm reviewing the type thing PR. I think we should remove the meetbot plugin.
<+xrl> Reason: I've never seen anyone using it, it's not well tested, and I'm not even sure it actually works.

Draft for now, because:

  • Merging Clean up errors in mypy --check-untyped-defs #2471 (the aforementioned "type thing PR") when it's finished will create a conflict
  • I'll want to update the extracted plugin file at https://github.com/sopel-irc/sopel-meetbot with the PR's changes to it, anyway
  • We probably shouldn't finalize this removal until a package is published, and I haven't converted the new plugin repo to a package yet (because I'm waiting until the first two points are taken care of)

This change leaves the references to meetbot in documentation for how to use the plugin-related settings in the bot's core config section, as they're just examples. No real reason to change them.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Notes

As usual I will add a review request to this PR when it's actually ready. I just realized tonight that I'm likely to forget the branch exists if I don't tie it to an open pull request. 😅

This change leaves the references to `meetbot` in documentation for how
to use the plugin-related settings in the bot's `core` config section,
as they're just examples. No real reason to change them.
@dgw dgw added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label Jun 17, 2023
@dgw dgw added this to the 8.0.0 milestone Jun 17, 2023
@dgw
Copy link
Member Author

dgw commented Jun 30, 2023

If anyone wants to test-run the package, it's in process at sopel-irc/sopel-meetbot#1

@dgw dgw requested a review from a team June 30, 2023 14:11
@dgw dgw marked this pull request as ready for review June 30, 2023 14:11
Copy link
Contributor

@SnoopJ SnoopJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The perfect PR doesn't exi-

Easy to approve this one, all red lines!

Might be worth making this the first thing that gets put into NEWS for 8.0 in this changeset, but not having it isn't a big deal for the actual changes.

@dgw dgw added the Breaking Change Stuff that probably should be mentioned in a migration guide label Jul 1, 2023
@dgw
Copy link
Member Author

dgw commented Jul 1, 2023

Might be worth making this the first thing that gets put into NEWS for 8.0

Reminded me that this should get the Breaking Change label, which is exactly what tells me things to mention first in the news, upgrade guide, etc. Thanks.

@dgw dgw mentioned this pull request Jul 3, 2023
40 tasks
@dgw dgw mentioned this pull request Jul 10, 2023
@dgw dgw merged commit 4fe14cc into master Jul 13, 2023
@dgw dgw deleted the rm-meetbot branch July 13, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Stuff that probably should be mentioned in a migration guide Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants