Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot, coretasks: remove obsolete URL callback mechanism #2436

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dgw
Copy link
Member

@dgw dgw commented Mar 26, 2023

Description

While we were happily discussing some future ideas on IRC today, I had a sudden flash of pure hatred for the fact that Sopel.call() still existed, and it felt very good to rip it out along with the only (deprecated) feature still using it.

I no longer want to wait until 9.0 dev starts to do this… Stuff like #2325 or #2435 would become much easier to implement without two different "call the thing" pipelines to worry about. In fact, the rate-related decorators already don't have the same effect when used on callables registered via this deprecated method (they don't handle the message added in #2290).

Vote in the poll on Twitter or Fediverse about whether it would be OK to do this in Sopel 8.0 instead of 9.0, as was promised in the upgrade guide and documentation for Sopel 7.x. (I'm hoping for a landslide voting result, so I can assign a milestone to this patch based on it. 🙃)

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Notes

Not that GitHub is The Only Place Sopel Plugins Exist, but I did a lang:Python code search here for register_url_callback and found 71 matching files, all of which were in clones of this repo. Not a one was a third-party plugin.

@dgw dgw added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant