Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: bump user-agent #2218

Merged
merged 2 commits into from Feb 20, 2022
Merged

url: bump user-agent #2218

merged 2 commits into from Feb 20, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 2, 2021

Description

Update the user-agent string to Chrome 96, the 2nd most popular UA listed on
https://techblog.willshouse.com/2012/01/03/most-common-user-agents/

Checklist

  • I have read CONTRIBUTING.md
    • I skimmed it, anyway.
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@ghost
Copy link
Author

ghost commented Dec 2, 2021

In theory this might help get less "are you a robot?" prompts? Bloomberg is at least one site this could be testing against, probably.

@dgw
Copy link
Member

dgw commented Dec 23, 2021

Don't let me forget about this before the next release, whether it's 7.1.8 or 8.0.0. But I don't want to merge it until we're close to a release, so the UA string doesn't get too stale again waiting for a new package.

We could also think about delegating this to a separate package users can update without needing a new Sopel release. PyPI has a surprisingly high number of packages dedicated to generating fake UAs.

@ghost
Copy link
Author

ghost commented Dec 23, 2021

Could also just be a bot owner configurable asset?

Like .set url.ua Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.45 Safari/537.36? Dunno; food for thought.

@dgw
Copy link
Member

dgw commented Dec 23, 2021

There's no .set command, but that's beside the point. Some kind of override could make sense if it's not pulled from something that can update as needed, independently of Sopel (or the eventual sopel-url plugin this should become).

@ghost
Copy link
Author

ghost commented Dec 23, 2021

There's no .set command

wondering how high dgw is

@dgw
Copy link
Member

dgw commented Dec 23, 2021

There's no .set command

wondering how high dgw is

sleep-deprived enough to confuse #1986 for an IRC command patch

@dgw dgw added this to the 7.1.8 milestone Feb 19, 2022
@dgw dgw added the Tweak label Feb 19, 2022
@ghost
Copy link
Author

ghost commented Feb 20, 2022

Is that what you wanted, @dgw?? 🤔

@dgw dgw changed the title bump user-agent url: bump user-agent Feb 20, 2022
@dgw dgw merged commit d3e7399 into sopel-irc:master Feb 20, 2022
dgw added a commit that referenced this pull request Feb 20, 2022
url: bump user-agent
@ghost ghost deleted the user-agent-update branch February 20, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant