Skip to content

Commit

Permalink
squashme comments [skip ci]
Browse files Browse the repository at this point in the history
  • Loading branch information
half-duplex committed Nov 13, 2023
1 parent 69812a6 commit 3aa7f37
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ check_untyped_defs = true
plugins = "sqlalchemy.ext.mypy.plugin"
show_error_codes = true

# Remove once scramp has type stubs or annotations
[[tool.mypy.overrides]]
module = 'scramp.*'
ignore_missing_imports = true
Expand Down
9 changes: 4 additions & 5 deletions test/coretasks/test_coretasks_sasl.py
Original file line number Diff line number Diff line change
Expand Up @@ -445,8 +445,8 @@ def test_sasl_scram_sha_256_auth(mockbot: Sopel):
)


def test_sasl_scram_sha_256_nonsense_server_first(mockbot: Sopel):
"""Verify the bot handles a nonsense SCRAM-SHA-256 server_first correctly."""
def test_sasl_scram_sha_256_invalid_server_first(mockbot: Sopel):
"""Verify the bot handles an invalid SCRAM-SHA-256 server_first correctly."""
mech = ScramMechanism()
salt, stored_key, server_key, iter_count = mech.make_auth_info(
"secret", iteration_count=5000
Expand All @@ -471,8 +471,8 @@ def test_sasl_scram_sha_256_nonsense_server_first(mockbot: Sopel):
)


def test_sasl_scram_sha_256_nonsense_server_final(mockbot: Sopel):
"""Verify the bot handles a nonsense SCRAM-SHA-256 server_final correctly."""
def test_sasl_scram_sha_256_invalid_server_final(mockbot: Sopel):
"""Verify the bot handles an invalid SCRAM-SHA-256 server_final correctly."""
mech = ScramMechanism()
salt, stored_key, server_key, iter_count = mech.make_auth_info(
"secret", iteration_count=5000
Expand Down Expand Up @@ -506,7 +506,6 @@ def test_sasl_scram_sha_256_nonsense_server_final(mockbot: Sopel):

def test_sasl_scram_sha_256_error_server_first(mockbot: Sopel):
"""Verify the bot handles an error SCRAM-SHA-256 server_first correctly."""

mockbot.settings.core.auth_method = "sasl"
mockbot.settings.core.auth_target = "SCRAM-SHA-256"
mockbot.on_message("CAP * LS :sasl")
Expand Down
1 change: 0 additions & 1 deletion test/test_coretasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
[core]
owner = Uowner
nick = TestBot
auth_password = hunter2
enable = coretasks
"""

Expand Down

0 comments on commit 3aa7f37

Please sign in to comment.