Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release integration for Sopel 8.0.0 #47

Merged
merged 4 commits into from
Jun 2, 2024
Merged

Release integration for Sopel 8.0.0 #47

merged 4 commits into from
Jun 2, 2024

Conversation

dgw
Copy link
Member

@dgw dgw commented Apr 28, 2024

This PR will serve as a pre-release integration point for all the moving parts that come with the new Sopel 8.0.0 release:

I'm opening this in a non-working state at first. Updating the _sopel/ submodule currently raises an unhelpful error in Netlify deploy logs as shown below, and I wanted to move debugging that out of #46 where I started it.

Cryptic Netlify error

image

Generally, it also just seems like a good idea to have an intermediate stop where all of the 8.0.0 updates will come together before they hit the site's production domain. Fixing unexpected build errors is less stressful on a PR branch than on master. 😁

Once _sopel/ is sorted out, other PRs about 8.0.0 prep can be edited to use this branch as their base instead.

The result of lengthy collaboration. Commit metadata does not *quite*
reflect the actual authorship timeline... ;-)

Co-authored-by: James <[email protected]>
Co-authored-by: mal <[email protected]>
@dgw dgw added this to the Sopel 8.0.0 milestone Apr 28, 2024
@dgw
Copy link
Member Author

dgw commented Apr 28, 2024

Ooh, this is gonna be a fun puzzle. We are going to need updates from #38 to build successfully with the updated _sopel/ submodule, and they will have to be done together. Otherwise Jekyll's link tag will fail the site build:

10:06:47 AM:   Liquid Exception: Could not find document '/docs/cli.html' in tag 'link'. Make sure the
               document exists and the path is correct. in /opt/build/repo/_usage/command-line-arguments.md

I knew reorganizing pages would come back to bite us one day! 😁

Edit: Merging #38 and applying a bit of extra fixum on top yielded a successful build. It might still contain some broken links that don't use the {% link %} Liquid tag, and/or some missing redirects, but it works.

This was referenced May 27, 2024
Upstream, `sopel/modules/` became `sopel/builtins/`, so the script here
to `document_sopel_plugins.py` had to be updated at the same time.

NOTE: This is a WIP commit, not pointing to the final version of 8.0.0!
@dgw dgw force-pushed the 8.0-release-integration branch from f9ba9e9 to a74fa39 Compare May 27, 2024 00:39
@dgw
Copy link
Member Author

dgw commented May 27, 2024

I misclicked and merged #38 direct to master (whoops), after cherry-picking a redirection update that breaks the build until the changes come in from upstream. So I rebased this branch onto master and pulled #46 in to do final testing.

@dgw dgw marked this pull request as ready for review May 27, 2024 00:43
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@dgw dgw force-pushed the 8.0-release-integration branch from 38f30e0 to 6cfd40e Compare June 2, 2024 05:57
@dgw dgw force-pushed the 8.0-release-integration branch from 6cfd40e to 4912e3e Compare June 2, 2024 06:10
@dgw dgw merged commit 0031475 into master Jun 2, 2024
4 checks passed
@dgw dgw deleted the 8.0-release-integration branch June 2, 2024 06:13
@dgw dgw mentioned this pull request Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants