Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: modernize the project and its packaging #9

Merged
merged 7 commits into from
Apr 27, 2024

Conversation

Exirel
Copy link
Collaborator

@Exirel Exirel commented Nov 11, 2023

This is a long overdue PR to modernize this plugin:

  • the instructions to run tests didn't work with latest version of pytest
  • pylint config was severely outdated
  • coverage wasn't 100%, unacceptable (no actually it was a choice with a plan to fix it quickly)
  • no more setup.py, welcome to modern Python packaging with pyproject.toml
  • and now, with an actual CI that runs for every PR (including this one, in theory)
  • a slightly reworked Makefile for good measure
  • within a virtualenv, you can now do make develop qa build then make release if you feel like it
  • using a .dev version for now

@Exirel
Copy link
Collaborator Author

Exirel commented Nov 11, 2023

Note: Python 3.7 to 3.10 only, as Py 3.6 wasn't supported anymore, and Py 3.11 isn't supported by Sopel 7.1.

In an effort to support the future (i.e. Sopel 8 and modern tooling),
Python 3.7 is now dropped for official support.

People using Sopel 7.1 can still use the perfectly fine previous version
0.4.0 of this plugin. Since Sopel 8 drops support for Py3.7, this
shouldn't be a problem for the future.
@Exirel Exirel added this to the 0.5.0 milestone Nov 11, 2023
@Exirel Exirel added the enhancement New feature or request label Apr 27, 2024
@Exirel Exirel merged commit d2315ef into master Apr 27, 2024
3 checks passed
@dgw dgw deleted the meta-modernize-packaging branch October 19, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant