Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returning view of method list to avoid CME #1953

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Returning view of method list to avoid CME #1953

wants to merge 1 commit into from
+1 −1

Commits on Feb 27, 2023

  1. Returning view of method list to avoid CME 

    The modified method `getMethodsByNameAndParamCount` is used (and only used) in the `FastHierarchy.getSignaturePolymorphicMethod` for resolving polymorphic methods. The for-loop will return the method list's iterator, but the list itself can be modified by another body pack transform thread, causing a `ConcurrentModificationException`. The patch fix the issue by returning a copy of this list.

This patch also fixes the issue soot-oss#1811 , and a similar issue is soot-oss#1199 (fixed by soot-oss#1886 ).
    @CirQ
    CirQ authored Feb 27, 2023
    Configuration menu
    Copy the full SHA
    7b832a0 View commit details
    Browse the repository at this point in the history