InvokeArgumentValidator changes #865
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissiety
reviewed
Feb 22, 2024
sootup.core/src/main/java/sootup/core/validation/InvokeArgumentValidator.java
Outdated
Show resolved
Hide resolved
sootup.core/src/main/java/sootup/core/validation/InvokeArgumentValidator.java
Show resolved
Hide resolved
sootup.tests/src/test/java/sootup/tests/validator/InvokeArgumentValidatorTest.java
Outdated
Show resolved
Hide resolved
sootup.tests/src/test/java/sootup/tests/validator/InvokeArgumentValidatorTest.java
Outdated
Show resolved
Hide resolved
1. Refactor the test case code as per the review comments for simplicity. 2. Implement argument type checking by including `rt.jar` in the analysis input locations, as the validator relies on typeHierarchy. Add a corresponding test case for this scenario. 3. Rectify a bug in `JavaIdentifierFactory.getBoxedType(...)` related to the int type. Replace the erroneous `java.lang.Int` with the correct type, which is `java.lang.Integer`. 4. Address a bug in `ArchiveBasedAnalysisInputLocation.getClassSource(...)` where attempting to cast `ClassType` to `JavaClassType` is incorrect. Update the code to handle `ClassType` appropriately, as it cannot be directly cast to `JavaClassType`.
Speed up the class search process by limiting the search scope within application classes, since classTypeFieldRefValidator does not exist in rt.jar
swissiety
reviewed
Feb 23, 2024
sootup.core/src/main/java/sootup/core/validation/InvokeArgumentValidator.java
Outdated
Show resolved
Hide resolved
...code/src/main/java/sootup/java/bytecode/inputlocation/ArchiveBasedAnalysisInputLocation.java
Outdated
Show resolved
Hide resolved
sootup.java.core/src/main/java/sootup/java/core/JavaIdentifierFactory.java
Outdated
Show resolved
Hide resolved
JonasKlauke
requested changes
Feb 28, 2024
| continue; | ||
| } | ||
| // other cases | ||
| ClassType argClassType = getClassType(identifierFactory, argType); |
There was a problem hiding this comment.
After the primitive type check the argument could still have the type: arraytype. You can not assume it is automatically a classtype.
|
|
||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
add a testcase for array types. Primitive type array, Classtype array and both cases also as multi-dimensional array
...code/src/main/java/sootup/java/bytecode/inputlocation/ArchiveBasedAnalysisInputLocation.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #865 +/- ##
=============================================
- Coverage 69.88% 69.71% -0.17%
- Complexity 4039 4044 +5
=============================================
Files 310 310
Lines 15248 15317 +69
Branches 2605 2624 +19
=============================================
+ Hits 10656 10679 +23
- Misses 3735 3782 +47
+ Partials 857 856 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rt.jarin the analysis input locations, as the validator relies on typeHierarchy. Add a corresponding test case for this scenario.JavaIdentifierFactory.getBoxedType(...)related to the int type. Replace the erroneousjava.lang.Intwith the correct type, which isjava.lang.Integer.ArchiveBasedAnalysisInputLocation.getClassSource(...)to avoid casting exception when passing an anonymousClassTypeobject which cannot be casted toJavaClassTypedirectly.