Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Qilin to SootUp-Experimental #1068

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

kadirayk
Copy link
Member

No description provided.

Copy link
Contributor

Documentation Preview.

…l-modules

# Conflicts:
#	sootup.qilin/pom.xml
#	sootup.qilin/src/main/java/qilin/core/builder/callgraph/OnFlyCallGraph.java
#	sootup.report/pom.xml
@JonasKlauke
Copy link
Collaborator

JonasKlauke commented Sep 20, 2024

one question: experimental is a fork of this repo. If we update the fork, wont it delete the entire qilin project 😄
I think we have to save the current state update the forked repo and create a commit containing the previous qilin

@JonasKlauke
Copy link
Collaborator

oh and dont forget to mention the experimental repo in the documentation with a link to the repo

@JonasKlauke
Copy link
Collaborator

JonasKlauke commented Sep 20, 2024

These dependencies could be also only used in qilin can you check the others pom and remove them in the parent pom

<dependency>
  <groupId>commons-cli</groupId>
  <artifactId>commons-cli</artifactId>
</dependency>
<dependency>
  <groupId>com.github.oshi</groupId>
  <artifactId>oshi-core</artifactId>
</dependency>
<dependency>
  <groupId>org.apache.commons</groupId>
  <artifactId>commons-lang3</artifactId>
</dependency>
<dependency>
  <groupId>commons-io</groupId>
  <artifactId>commons-io</artifactId>
</dependency>

@kadirayk
Copy link
Member Author

one question: experimental is a fork of this repo. If we update the fork, wont it delete the entire qilin project 😄 I think we have to save the current state update the forked repo and create a commit containing the previous qilin

I think we'll be able to keep it when resolving merge conflicts but it will be cumbersome. We should rethink about this.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.91%. Comparing base (ecba93c) to head (d54a9e6).
Report is 21 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #1068       +/-   ##
==============================================
+ Coverage      39.68%   62.91%   +23.22%     
- Complexity      4448     4456        +8     
==============================================
  Files            659      439      -220     
  Lines          29627    18715    -10912     
  Branches        4839     3121     -1718     
==============================================
+ Hits           11757    11774       +17     
+ Misses         16959     6028    -10931     
- Partials         911      913        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kadirayk
Copy link
Member Author

these are used in other modules

<dependency>
  <groupId>org.apache.commons</groupId>
  <artifactId>commons-lang3</artifactId>
</dependency>
<dependency>
  <groupId>commons-io</groupId>
  <artifactId>commons-io</artifactId>
</dependency>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants