Implement call graph pruning feature #1025
Conversation
sootup.callgraph/src/main/java/sootup/callgraph/AbstractCallGraphAlgorithm.java
Outdated
Show resolved
Hide resolved
| public void setBoundFunction(BiFunction<SootMethod, InvokableStmt, Boolean> boundFunction) | ||
| { | ||
| this.boundFunction = boundFunction; | ||
| } |
There was a problem hiding this comment.
lets set the function in the constructor only
There was a problem hiding this comment.
hmm.... but this would force all sub-classes implement two constructors - one with a bound function, one without (so to use the always-true function)..... instead of having this feature automatically
let's keep it this way, or change setter to a "with" method (fluent API)?
There was a problem hiding this comment.
if you are concerned bound function is set after constructCompleteCallGraph() is called, I can add a checker and throw an exception if user do that. thought?
There was a problem hiding this comment.
lets implement it as a method directly without BiPredicate etc. - that way someone can override it the same way its done with a linkedhashmap to transform it to a LRUcache via overriding removeoldestentry() - e.g. see https://ashcode.medium.com/lru-cache-using-linkedhashmap-java-85e78ee1b976
There was a problem hiding this comment.
I would still recommend keeping it this way. This is more a setting of the analyser than an extension to it. In general I would try to avoid overriding a non-abstract method, it's kind of breaking encapsulation. In general composition is preferred than inheritance, see https://en.wikipedia.org/wiki/Composition_over_inheritance
There was a problem hiding this comment.
I think if you configure it in the constructor, the developer might be more aware of the feature.
lets use BiPredicate as type to reduce unnecessary AutoBoxing and simplify the condition check to just the method call
Generating large call graph can be slow and consumes large memory.
This feature allows pruning the call graph with a bound function, so to generate an incomplete call graph according to the analysis algorithm user's specific needs - with potentially less memory & CPU usage.