V2 #61
Merged
V2 #61
+858
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…54) * gobreaker/v2: added generics implementation in v2 module * gobreaker/v2/example: added v2 example * gobreaker/README: updated README.md * fixup! gobreaker/v2: added generics implementation in v2 module --------- Co-authored-by: Yoshiyuki Mineo <[email protected]>
puellanivis
reviewed
Aug 28, 2024
| // with the breaker functionality, it only checks whether a request can proceed and | ||
| // expects the caller to report the outcome in a separate step using a callback. | ||
| type TwoStepCircuitBreaker[T any] struct { | ||
| cb *CircuitBreaker[T] |
There was a problem hiding this comment.
Since this type doesn’t use the type parameter at all, this could have just wrapped *CircuitBreaker[struct{}] rather than bubbling up an unnecessary type param into this type?
I suppose, removing the type parameter would now be a breaking change, though…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.