[crm][dash] Do not probe DASH resources on devices other than the DPU. #3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
approved these changes
Sep 24, 2024
|
@prsunny this is urgent fix for master stability. can you please help to approve and merge? |
dgsudharsan
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Probe the DASH resource only when run on the DPU.
Why I did it
The changes optimize the CRM Orch to not access the DASH resources when it is clear that the device running the SONiC doesn't support them.
Also this prevents potential SAI library incompatibility caused by SAI metadata changes introduced in opencomputeproject/SAI#2028 PR
How I verified it
Run CRM UT.
Details if related