[fdborch] Only call flushFDBEntries() when there is a bridge port OID in port state update #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
approved these changes
May 19, 2023
mint570
force-pushed
the
fdb_log_upstream
branch
from
21bf9ce
to
ac85f91
Compare
mint570
force-pushed
the
fdb_log_upstream
branch
from
ac85f91
to
cca0031
Compare
a bridge port OID.
mint570
force-pushed
the
fdb_log_upstream
branch
from
cca0031
to
eb3553f
Compare
prsunny
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Only call flushFDBEntries() when there is a bridge port OID in port state update for fdborch.
Why I did it
The flushFDBEntries() has the check at the beginning. But it is wrong to call the function to begin with.
This will get rid of the false warning log message in flushFDBEntries().
How I verified it
Details if related