Close socket descriptor in checkPortIffUp. (#3263)

What I did Close socket descriptor in checkPortIffUp. Why I did it Currently the file descriptor is not closed. It will cause descriptor leak.
sonic-net · Sep 24, 2024 · 002cd25 · 002cd25
1 parent 69cf087
commit 002cd25
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/cfgmgr/teammgr.cpp b/cfgmgr/teammgr.cpp
@@ -396,11 +396,15 @@ bool TeamMgr::checkPortIffUp(const string &port)
     if (fd == -1 || ioctl(fd, SIOCGIFFLAGS, &ifr) == -1)
     {
         SWSS_LOG_ERROR("Failed to get port %s flags", port.c_str());
+        if (fd != -1)
+        {
+            close(fd);
+        }
         return false;
     }
 
     SWSS_LOG_INFO("Get port %s flags %i", port.c_str(), ifr.ifr_flags);
-
+    close(fd);
     return ifr.ifr_flags & IFF_UP;
 }