New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sonic-db-cli: Don't use unix socket for redis_chassis.server #873

Merged

judyjoseph merged 1 commit into sonic-net:master from arista-nwolfe:master-sonic-db-cli-chassis-app-db

Jun 12, 2024

Contributor

arista-nwolfe commented May 1, 2024

Described in sonic-net/sonic-buildimage#18733 we see that swss.sh will try to access CHASSIS_APP_DB via sonic-db-cli.
If we're on a multi-asic system it will include the -n <asic> argument.
Having the -n <asic> argument causes sonic-db-cli to use unix sockets due to #797
If we use a unix socket to try to reach the supervisor from the LC the command will fail with:

admin@cmp217-5:/var/log$ sudo sonic-db-cli -n asic0 CHASSIS_APP_DB keys "*"
Invalid database name input : 'CHASSIS_APP_DB'
Unable to connect to redis (unix-socket): Cannot assign requested address

#866 fixed a similar issue with database.sh by forcing a tcp connection when accessing CHASSIS_APP_DB (redis_chassis.server) specifically for the PING SAVE and FLUSHALL operations.
This change provides that same tcp connection override for the other operations.

Contributor Author

arista-nwolfe commented May 1, 2024

Tagging @mlok-nokia to confirm if this is a viable solution to the CHASSIS_APP_DB unix socket issue on multi-asic LCs we discussed in the meeting today.

arista-nwolfe changed the title ~~sonic-db-cli: Don't use unix socket on for redis_chassis.server~~ sonic-db-cli: Don't use unix socket for redis_chassis.server

Contributor

mlok-nokia commented May 2, 2024

Tagging @mlok-nokia to confirm if this is a viable solution to the CHASSIS_APP_DB unix socket issue on multi-asic LCs we discussed in the meeting today.

This fix looks good to me. It uses the same mechanism as how it has been handled in the local host. I think we can use this fix to make sonic-db-cli command behaves the same as 202205 branch.

mlok-nokia approved these changes

View reviewed changes

Contributor

mlok-nokia left a comment

It looks good to me.

arlakshm requested review from liuh-80 and qiluo-msft

May 3, 2024 20:59

rlhui added the P0 label

rlhui commented May 15, 2024

@qiluo-msft ping again, thx

arista-nwolfe force-pushed the master-sonic-db-cli-chassis-app-db branch from b440ed9 to c7dcd0d Compare

May 15, 2024 17:14

arlakshm approved these changes

View reviewed changes

Contributor

qiluo-msft commented May 17, 2024

sonic-db-cli is behaving similar to redis-cli. If user provide options.m_unixsocket, we should stick with it. Even in existing code, I do not understand why options.m_unixsocket could be changed.

Contributor

arlakshm commented May 17, 2024 •

edited

Loading

sonic-db-cli is behaving similar to redis-cli. If user provide options.m_unixsocket, we should stick with it. Even in existing code, I do not understand why options.m_unixsocket could be changed.

@qiluo-msft in the PR, #797, change was made to always use unix socket when passing the namespace option to the sonic-db-cli command.
The user option is overwritten to use unixsocket in this case

This PR is fixing communication to chassis redis instance from namespace in the linecard, because we cannot use unixsocket in this case.

Contributor

lguohan commented May 29, 2024

@qiluo-msft , can you check this one?

Collaborator

judyjoseph commented Jun 5, 2024

@arista-nwolfe could you rebase this branch


          Don't use unix socket on for redis_chassis.server

d8330cf

arista-nwolfe force-pushed the master-sonic-db-cli-chassis-app-db branch from c7dcd0d to d8330cf Compare

June 5, 2024 17:08

judyjoseph added the Request for 202405 Branch label

liuh-80 approved these changes

View reviewed changes

judyjoseph merged commit e37bfea into sonic-net:master

17 checks passed

bingwang-ms added the Approved for 202405 Branch label

mssonicbld pushed a commit to mssonicbld/sonic-swss-common that referenced this pull request


          Don't use unix socket on for redis_chassis.server (sonic-net#873)

cd8dc7d

mssonicbld mentioned this pull request

[action] [PR:873] Don't use unix socket on for redis_chassis.server (#873) #883

Merged

mssonicbld added the Created PR to 202405 Branch label

Collaborator

mssonicbld commented Jun 12, 2024

Cherry-pick PR to 202405: #883

Collaborator

mssonicbld commented Jun 15, 2024

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!!
#883

5 similar comments

Collaborator

mssonicbld commented Jun 16, 2024

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!!
#883

Collaborator

mssonicbld commented Jun 17, 2024

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!!
#883

Collaborator

mssonicbld commented Jun 18, 2024

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!!
#883

Collaborator

mssonicbld commented Jun 19, 2024

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!!
#883

Collaborator

mssonicbld commented Jun 20, 2024

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!!
#883

Collaborator

mssonicbld commented Jun 21, 2024

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!!
#883

arfeigin pushed a commit to arfeigin/sonic-swss-common that referenced this pull request


          Don't use unix socket on for redis_chassis.server (sonic-net#873)

d65b47a

Collaborator

mssonicbld commented Jul 8, 2024

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days.
#883

4 similar comments

Collaborator

mssonicbld commented Jul 9, 2024

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days.
#883

Collaborator

mssonicbld commented Jul 10, 2024

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days.
#883

Collaborator

mssonicbld commented Jul 11, 2024

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days.
#883

Collaborator

mssonicbld commented Jul 19, 2024

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days.
#883

Contributor

qiluo-msft commented Jul 19, 2024

@arista-nwolfe Could you check why #883 is failing

Contributor Author

arista-nwolfe commented Jul 20, 2024

@arista-nwolfe Could you check why #883 is failing

I was told that there is a dependency issue in sonic-swss-common on 202405 causing all builds to fail.
Tagging @arlakshm here.

I'm not sure why the 202405 cast was closed.

arista-nwolfe added a commit to arista-nwolfe/sonic-swss-common that referenced this pull request


          Don't use unix socket on for redis_chassis.server (sonic-net#873)

8d6d1d8

arista-nwolfe mentioned this pull request

[202405] Don't use unix socket on for redis_chassis.server (sonic-net#873) #896

Closed

wenyiz2021 mentioned this pull request

[action] [cherry pick] [PR:873] Don't use unix socket on for redis_chassis.server #902

Closed

wenyiz2021 pushed a commit that referenced this pull request


          Don't use unix socket on for redis_chassis.server (#873) (#883)

4fecc2f

Cherry pick PR 873 into 202405

bingwang-ms added the Included in 202405 Branch label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved for 202405 Branch Created PR to 202405 Branch Included in 202405 Branch P0 Request for 202405 Branch