Use selectable event to terminate logger thread #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kcudnik , could you please kindly review and provide comments? |
Junchao-Mellanox
force-pushed
the
master-log-enhance
branch
from
efbc276 to
8befade
Compare
stephenxs
approved these changes
Jan 15, 2024
|
This looks good, is this one second causing some issues ? |
kcudnik
reviewed
Jan 15, 2024
I would like to use this logger in Python, and the python code could be referred by CLI. It causes a 1 sec delay in CLI call. |
|
Hi @kcudnik , I have fixed the comments, could you please check? |
kcudnik
approved these changes
Jan 16, 2024
|
Hi @kcudnik , could you help merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
settingThreadofLoggerselect DB change with 1000ms timeout. It causes up to 1 second wait while destroy the logger instance. The 1 second wait is not necessary and can be replaced bySelectableEventWork item tracking
How I did it
settingThreadalso selects m_stopEventsettingThreadexits if m_stopEvent comesHow to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)