Adding vpp platform #1424
Adding vpp platform #1424
Conversation
|
lgtm. @kcudnik to check. |
| meta/Meta.h usr/include/sai | ||
| meta/AttrKeyMap.h usr/include/sai | ||
| meta/MetaKeyHasher.h usr/include/sai | ||
| meta/OidRefCounter.h usr/include/sai | ||
| meta/PortRelatedSet.h usr/include/sai | ||
| meta/Notification*.h usr/include/sai | ||
| meta/Globals.h usr/include/sai |
There was a problem hiding this comment.
not sure if this is good idea to make those headers part of this package
There was a problem hiding this comment.
why you need those headers be present here ?
There was a problem hiding this comment.
sonic-vpp is morphed from sonic-vs. Similar to vs, it uses classes from sonic-sairedis/meta so we need to export the header files from libsaimetata-dev.
There was a problem hiding this comment.
ok, let see how it will go
There was a problem hiding this comment.
Thanks. What's the next step for this PR?
|
i will need some meeting to discuss vpp platform to understand what is the long term goal here |
Sounds good. When will be a good time for you? |
|
vpp sai is the same concept as dash sai, instead of bmv2 implementation, this is dataplane implementation on top of vpp. the difference between bmv2 v.s vpp is the vpp will implementation API more like traditional switches asic, while bmv2 is on the dpu. https://github.com/sonic-net/DASH/tree/main/dash-pipeline/SAI/src |
|
it seems for me like vpp is concept of another virtual switch, my question is why we need another virtual switch next to sairedis-VS and DASH bmv2 implementation? why we need to keep track and maintain of 3 virtual switches ? |
vpp is a very popular data plane with rich features. I am not familiar with vs but Riff and Jing have done some research evaluating the vpp and vs platform. @r12f and @zjswhhh , can you please share your research? bmv2 is a completely different data plane. It implements DPU while vpp and vs implement NPU functionalities. |
|
This still sounds like maintaining 3 different virtual switches at the same time |
|
Hi @kcudnik - sonic vs platform only supports control plane. We wanted to be able to do data plane validate with virtual testbeds too, that was the intention for adding vpp platform. We can't hold feature development till hardware is ready. We need virtual testbeds to provide more. I have presented a smartswitch test plan based on vpp platform in community meeting. This is one example of the use case of vpp platform.
|
why
VPP is a new platform of SONiC. Here is the HLD: https://github.com/sonic-net/sonic-platform-vpp/blob/main/docs/HLD/SONICVPP-HLD.md. Currently, VPP is built by patching itself on top of VS platform, which requires it carrying a lot of diffs. It is very difficult to upgrade SONiC because patch may have a lot of conflicts. We will make VPP a platform as any other platforms to avoid patching.
What this change is doing
VPP SAI layer is built on top of vslib. It uses some classes from sonic-sairedis/meta so we need to export the header files from libsaimetata-dev.
This PR also adds some vpp specific logic to syncd_init_common.sh before starting syncd.