Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic sensor logic for fixed and psu presence/state checking in thermalctld, 202205 merge conflicts addressed #409

Conversation

gregoryboudreau
Copy link
Contributor

Add dynamic sensor logic for fixed and psu presence/state checking in thermalctld. As requested, creating separate double commit for 202205 to address merge conflict.

Description

Extends the existing dynamic sensor logic of modular chassis to fixed and adds a check for PSU presence/status in thermalctld

Motivation and Context

In current form, if a PSU or other device with sensors is removed from the device or disabled during runtime on a fixed chassis, they will become stale and remain in the temperature sensor DB which should not be correct. This change brings the existing logic checks that modular chassis' have to fixed platform as well as checks for PSU presence/status to account for scenario where PSU may be disabled during runtime.

How Has This Been Tested?

On both fixed and modular platforms (Cisco 8800RP and Cisco 8101_32FH), I confirmed presence of all thermal sensors. Then disable the PSU and confirmed its associated sensors were removed from the DB while it was either inactive and present or not present. Reenabled PSU and confirmed its associated sensors were updated back into the DB. test_show_platform.py::test_show_platform_temperature passes.

Additional Information (Optional)
For more context, please see #401

@gechiang
Copy link
Contributor

gechiang commented Dec 6, 2023

@yxieca please help approve/merge this PR that @gregoryboudreau has made to resolve the cherry-pick issue.
copied the MSFT ADO here for your reference: MSFT ADO: 25872447
Thanks!

@yxieca yxieca merged commit e8faab0 into sonic-net:202205 Dec 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants