Added new Platform APIs and modified APIs for supporting reboot on a SmartSwitch #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvolam
requested review from
rameshraghupathy,
oleksandrivantsiv and
prgeor
prgeor
reviewed
Sep 25, 2024
prgeor
reviewed
Sep 25, 2024
prgeor
reviewed
Sep 25, 2024
prgeor
reviewed
Sep 25, 2024
oleksandrivantsiv
approved these changes
Sep 25, 2024
prgeor
approved these changes
Sep 27, 2024
| @@ -258,6 +262,31 @@ def get_state_info(self): | |||
| """ | |||
| raise NotImplementedError | |||
|
|
|||
| def get_bus_info(self, module_name): | |||
| """ | |||
| Retrieves the bus information for the specified by "module_name" on a SmartSwitch. | |||
There was a problem hiding this comment.
I guess you intended to say "Retrieves the bus information for the module specified"
| """ | ||
| Detaches the DPU PCI device specified by "module_name" on a SmartSwitch. | ||
|
|
||
| Returns: True once the PCI is successfully detached. |
There was a problem hiding this comment.
Can you also call out the negative case? Also, mention how the platform is informed to recover form this.
| """ | ||
| Rescans and reconnects the DPU PCI device specified by "module_name" on a SmartSwitch. | ||
|
|
||
| Returns: True once the PCI is successfully reconnected. |
There was a problem hiding this comment.
Can you also call out the negative case? Also, mention how the platform is informed to recover form this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new APIs and modified reboot API in module_base.py for supporting reboot on a SmartSwitch.
Motivation and Context
These API enhancements are required to support reboot for new SmartSwitch platforms. All the requirements are captured in reboot HLD
How Has This Been Tested?
Modified module_base.py tests. New reboot CLI changes will invoke these APIs.
Additional Information (Optional)