Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202305] Add new SSD type support #396

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

Junchao-Mellanox
Copy link
Contributor

Description

Backport PR #390 to 202305

Add new SSD vendor "Swissbit" support

Motivation and Context

Add new SSD vendor "Swissbit" support

How Has This Been Tested?

Unit test
Manual test

Additional Information (Optional)

@Junchao-Mellanox
Copy link
Contributor Author

/azpw run Azure.sonic-platform-common

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-platform-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS
Copy link

@Junchao-Mellanox could you help to take a look at this build failure?

* Add new SSD type support

* Fix review comment

---------

Co-authored-by: Prince George <[email protected]>
Conflicts:
	sonic_platform_base/sonic_ssd/ssd_generic.py
@Junchao-Mellanox
Copy link
Contributor Author

Hi @StormLiangMS , fixed

@dgsudharsan
Copy link
Collaborator

@StormLiangMS Can you please help merge this?

@StormLiangMS StormLiangMS merged commit 67745c8 into sonic-net:202305 Sep 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants