Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:17211] [bgp] Add bgp router id test #17284

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Add test for bgp router id: #16896

How did you do it?

  1. Test in default config, bgp router id should be aligned with Loopback IPv4 address
  2. Test when bgp_router_id and Loopback IPv4 address both exist in running config, bgp router id should be aligned with bgp_router_id in running config. And Loopback IPv4 address should be advertised to neighbor
  3. Test when bgp_router_id configured but Loopback IPv4 address missing, bgp could work well.

How did you verify/test it?

Run test in m0/t0/t1/dualtor/dualtor-aa testbed, all passed

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

How did you do it?
Test in default config, bgp router id should be aligned with Loopback IPv4 address
Test when bgp_router_id and Loopback IPv4 address both exist in running config, bgp router id should be aligned with bgp_router_id in running config. And Loopback IPv4 address should be advertised to neighbor
Test when bgp_router_id configured but Loopback IPv4 address missing, bgp could work well.

How did you verify/test it?
Run test in m0/t0/t1/dualtor/dualtor-aa testbed, all passed
@mssonicbld mssonicbld requested a review from StormLiangMS as a code owner March 3, 2025 03:43
@mssonicbld
Copy link
Collaborator Author

/azp run

@mssonicbld
Copy link
Collaborator Author

Original PR: #17211

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit d2ffd6b into sonic-net:202411 Mar 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants