Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[radv_ipv6_ra]: Fix the hardcode interface for IPv6 advertisement interface #17275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pterosaur
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

In some testbeds, eth1 isn't always present. This PR is to enhance the test case to support the testbed without eth1.

How did you do it?

Replace the ptf_port_index as IPv6 advertisement interface which will be always present in the testbed.

How did you verify/test it?

radv/test_radv_ipv6_ra.py::test_radv_router_advertisement PASSED                                      [ 25%]
radv/test_radv_ipv6_ra.py::test_solicited_router_advertisement PASSED                                [ 50%]
radv/test_radv_ipv6_ra.py::test_unsolicited_router_advertisement_with_m_flag PASSED       [ 75%]
radv/test_radv_ipv6_ra.py::test_solicited_router_advertisement_with_m_flag PASSED           [ 100%]

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@Pterosaur Pterosaur requested a review from r12f March 2, 2025 15:00
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Ze!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants