Fix test_dynamic_acl incompatible issue on dualtor #17274
Merged
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhaohui Sun <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ZhaohuiS
changed the title
Signed-off-by: Zhaohui Sun <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 3, 2025
* Fix test_dynamic_acl uncompatible issue on dualtor Signed-off-by: Zhaohui Sun <[email protected]> Description of PR Summary: Fixes # (issue) test_dynamic_acl failed on dualtor testbed due to: 28/02/2025 16:40:42 __init__._fixture_func_decorator L0073 ERROR | AttributeError("'AnsibleUnsafeText' object has no attribute 'get'") Traceback (most recent call last): File "/data/tests/common/plugins/log_section_start/__init__.py", line 71, in _fixture_func_decorator return fixture_func(*args, **kargs) File "/data/tests/generic_config_updater/test_dynamic_acl.py", line 227, in setup if config_facts['VLAN_INTERFACE'][vlan_name][vlan_ip_address].get("secondary"): AttributeError: 'AnsibleUnsafeText' object has no attribute 'get' It's because the VLAN_INTERFACE is like this on dualtor: "VLAN_INTERFACE": { "Vlan1000": { "grat_arp": "enabled", "proxy_arp": "enabled", "192.168.0.1/21": { }, "fc02:1000::1/64": { } } }, Approach What is the motivation for this PR? How did you do it? Avoid to get secondary key from a string object Signed-off-by: Zhaohui Sun <[email protected]>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 3, 2025
* Fix test_dynamic_acl uncompatible issue on dualtor Signed-off-by: Zhaohui Sun <[email protected]> Description of PR Summary: Fixes # (issue) test_dynamic_acl failed on dualtor testbed due to: 28/02/2025 16:40:42 __init__._fixture_func_decorator L0073 ERROR | AttributeError("'AnsibleUnsafeText' object has no attribute 'get'") Traceback (most recent call last): File "/data/tests/common/plugins/log_section_start/__init__.py", line 71, in _fixture_func_decorator return fixture_func(*args, **kargs) File "/data/tests/generic_config_updater/test_dynamic_acl.py", line 227, in setup if config_facts['VLAN_INTERFACE'][vlan_name][vlan_ip_address].get("secondary"): AttributeError: 'AnsibleUnsafeText' object has no attribute 'get' It's because the VLAN_INTERFACE is like this on dualtor: "VLAN_INTERFACE": { "Vlan1000": { "grat_arp": "enabled", "proxy_arp": "enabled", "192.168.0.1/21": { }, "fc02:1000::1/64": { } } }, Approach What is the motivation for this PR? How did you do it? Avoid to get secondary key from a string object Signed-off-by: Zhaohui Sun <[email protected]>
|
Cherry-pick PR to 202405: #17287 |
|
Cherry-pick PR to 202411: #17286 |
This was referenced Mar 3, 2025
mssonicbld
pushed a commit
that referenced
this pull request
Mar 3, 2025
* Fix test_dynamic_acl uncompatible issue on dualtor Signed-off-by: Zhaohui Sun <[email protected]> Description of PR Summary: Fixes # (issue) test_dynamic_acl failed on dualtor testbed due to: 28/02/2025 16:40:42 __init__._fixture_func_decorator L0073 ERROR | AttributeError("'AnsibleUnsafeText' object has no attribute 'get'") Traceback (most recent call last): File "/data/tests/common/plugins/log_section_start/__init__.py", line 71, in _fixture_func_decorator return fixture_func(*args, **kargs) File "/data/tests/generic_config_updater/test_dynamic_acl.py", line 227, in setup if config_facts['VLAN_INTERFACE'][vlan_name][vlan_ip_address].get("secondary"): AttributeError: 'AnsibleUnsafeText' object has no attribute 'get' It's because the VLAN_INTERFACE is like this on dualtor: "VLAN_INTERFACE": { "Vlan1000": { "grat_arp": "enabled", "proxy_arp": "enabled", "192.168.0.1/21": { }, "fc02:1000::1/64": { } } }, Approach What is the motivation for this PR? How did you do it? Avoid to get secondary key from a string object Signed-off-by: Zhaohui Sun <[email protected]>
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Mar 3, 2025
* Fix test_dynamic_acl uncompatible issue on dualtor Signed-off-by: Zhaohui Sun <[email protected]> Description of PR Summary: Fixes # (issue) test_dynamic_acl failed on dualtor testbed due to: 28/02/2025 16:40:42 __init__._fixture_func_decorator L0073 ERROR | AttributeError("'AnsibleUnsafeText' object has no attribute 'get'") Traceback (most recent call last): File "/data/tests/common/plugins/log_section_start/__init__.py", line 71, in _fixture_func_decorator return fixture_func(*args, **kargs) File "/data/tests/generic_config_updater/test_dynamic_acl.py", line 227, in setup if config_facts['VLAN_INTERFACE'][vlan_name][vlan_ip_address].get("secondary"): AttributeError: 'AnsibleUnsafeText' object has no attribute 'get' It's because the VLAN_INTERFACE is like this on dualtor: "VLAN_INTERFACE": { "Vlan1000": { "grat_arp": "enabled", "proxy_arp": "enabled", "192.168.0.1/21": { }, "fc02:1000::1/64": { } } }, Approach What is the motivation for this PR? How did you do it? Avoid to get secondary key from a string object Signed-off-by: Zhaohui Sun <[email protected]>
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
test_dynamic_acl failed on dualtor testbed due to:
It's because the VLAN_INTERFACE is like this on dualtor:
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
Avoid to get
secondarykey from a string objectHow did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation