[Test Gap][decap][t0] Add testcase to verify the decap rules are working before and after warm-reboot #17262
+47
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ryanzhu706
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vaibhavhd
reviewed
Mar 1, 2025
There was a problem hiding this comment.
We can't move the test to a common directory. tests/common is a place for common utilities to be used by two or more tests. So the decap test still has to live inside tests/decap
| @@ -18,6 +18,8 @@ | |||
| from tests.common.mellanox_data import is_mellanox_device | |||
| from tests.common.platform.reboot_timing_constants import SERVICE_PATTERNS, OTHER_PATTERNS, SAIREDIS_PATTERNS, \ | |||
| OFFSET_ITEMS, TIME_SPAN_ITEMS, REQUIRED_PATTERNS | |||
| from tests.common.platform.test_subnet_decap import build_encapsulated_vlan_subnet_packet, \ | |||
There was a problem hiding this comment.
Please move the test back to decap dir. Move the logic that is to be used (build_encapsulated_vlan_subnet_packet) by both decap and advanced_reboot case to a common location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Test Gap Description
No testcase to validate the decap rules are created/working as expected after warm-reboot.
Note: This particular test case can be covered in dedicated upgrade path test.
Test Plan
verify the decap rules are present and IPinIP traffic could be decapsulated before warm reboot
warm reboot to a newer version
verify the decap rules are present and IPinIP traffic could be decapsulated after warm reboot
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
No testcase to validate the decap rules are created/working as expected after warm-reboot.
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation