feat: enable forced mgmt route test on T2 #17210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Mar 3, 2025
Description of PR Enable route/test_forced_mgmt_route.py::test_update_forced_mgmt test case on T2 topo to resolve the T2 test gap. Summary: Fixes # (issue) Microsoft ADO 28837282 Approach What is the motivation for this PR? We want to run more tests on T2 topo to increase the test coverage. In this PR, we enabled route/test_forced_mgmt_route.py::test_update_forced_mgmt on T2 topo. The other test case test_forced_mgmt_route_add_and_remove_by_mgmt_port_status() will still be skipped for multi-asic devices (for example, T2 devices) as I couldn't find a device with eth1 port available, so I never got the chance to verify it. I have created a GitHub issue here to track this: sonic-net#17250 How did you do it? How did you verify/test it? Elastictest link: https://elastictest.org/scheduler/testplan/67bf90c1fdc60a30648c223b?testcase=route%2Ftest_forced_mgmt_route.py&type=console&leftSideViewMode=detail co-authorized by: [email protected]
|
Cherry-pick PR to 202411: #17279 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Mar 3, 2025
Description of PR Enable route/test_forced_mgmt_route.py::test_update_forced_mgmt test case on T2 topo to resolve the T2 test gap. Summary: Fixes # (issue) Microsoft ADO 28837282 Approach What is the motivation for this PR? We want to run more tests on T2 topo to increase the test coverage. In this PR, we enabled route/test_forced_mgmt_route.py::test_update_forced_mgmt on T2 topo. The other test case test_forced_mgmt_route_add_and_remove_by_mgmt_port_status() will still be skipped for multi-asic devices (for example, T2 devices) as I couldn't find a device with eth1 port available, so I never got the chance to verify it. I have created a GitHub issue here to track this: #17250 How did you do it? How did you verify/test it? Elastictest link: https://elastictest.org/scheduler/testplan/67bf90c1fdc60a30648c223b?testcase=route%2Ftest_forced_mgmt_route.py&type=console&leftSideViewMode=detail co-authorized by: [email protected]
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Enable
route/test_forced_mgmt_route.py::test_update_forced_mgmttest case on T2 topo to resolve the T2 test gap.Summary:
Fixes # (issue) Microsoft ADO 28837282
Type of change
Back port request
Approach
What is the motivation for this PR?
We want to run more tests on T2 topo to increase the test coverage. In this PR, we enabled
route/test_forced_mgmt_route.py::test_update_forced_mgmton T2 topo.The other test case
test_forced_mgmt_route_add_and_remove_by_mgmt_port_status()will still be skipped for multi-asic devices (for example, T2 devices) as I couldn't find a device witheth1port available, so I never got the chance to verify it. I have created a GitHub issue here to track this: #17250How did you do it?
How did you verify/test it?
Elastictest link: https://elastictest.org/scheduler/testplan/67bf90c1fdc60a30648c223b?testcase=route%2Ftest_forced_mgmt_route.py&type=console&leftSideViewMode=detail
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation