Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hget_all in SonicDbCli #14846

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bingwang-ms
Copy link
Collaborator

Description of PR

Summary:
Fix #14816

The PR takes the implementation from PR #13574
PR #13574 was reverted, but the function hget_all has been referenced in some other code.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

This PR is to add support for hget_all in SonicDbCli.

How did you do it?

Implement hget_all funciton.

How did you verify/test it?

The change is verified by running test_lldp_syncd.
collected 5 items

lldp/test_lldp_syncd.py::test_lldp_entry_table_keys[str-msn2700a1-03] PASSED [ 20%]
lldp/test_lldp_syncd.py::test_lldp_entry_table_content[str-msn2700a1-03] PASSED [ 40%]
lldp/test_lldp_syncd.py::test_lldp_entry_table_after_flap[str-msn2700a1-03] SKIPPED (Skipping test for eth0 interface) [ 60%]
lldp/test_lldp_syncd.py::test_lldp_entry_table_after_lldp_restart[str-msn2700a1-03] PASSED [ 80%]
lldp/test_lldp_syncd.py::test_lldp_entry_table_after_reboot[str-msn2700a1-03] ^HPASSED [100%]

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

Not a new test case.

Documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [202405] lldp/test_lldp_syncd.py failing on 202405 branch due to mising hget_all() function
1 participant