refactor: move skip condition to tests mark #14798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Move the multi-asic skip condition in
override_config_table/test_override_config_table.pytotest_mark_conditions.yamlto speed up the skip process.Summary:
Fixes # (issue) Microsoft ADO 29658311
Type of change
Back port request
Approach
What is the motivation for this PR?
Currently, it takes 1 ~ 2 hours to skip the
override_config_table/test_override_config_table.pytest on T2 chassis because there are some unnecessary setup steps before it reaches multi-asicpytest.skip()condition. We can improve this by moving the skip condition totest_mark_conditions.yaml.How did you do it?
How did you verify/test it?
I ran the updated code in T2 chassis and it only took ~1 min to skip the test. Meanwhile, I can confirm that this test is running as normal in single-asic Testbeds.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation