[action] [PR:14792] Fix customMsg from unexpected sanity failure #14796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New feature delivered recently, add customMsg for sanity check failures, was causing unexpected sanity_check results. This was due to premature cache key reset of pre_sanity_check_failed and post_sanity_check_failed. Removed those two keys from getting reset before sessionfinish to resolve the issue Important cache keys, used to determine session exit status: pre_sanity_check_failed & post_sanity_check_failed => These combination of keys will return exit status 10, 11, 12 10 = PRE_SANITY_CHECK_FAILED_RC 11 = POST_SANITY_CHECK_FAILED_RC 12 = SANITY_CHECK_FAILED_RC duthosts_fixture_failed => If this is true, we return exit status code 15 15 = DUTHOSTS_FIXTURE_FAILED_RC Description of PR Summary: New feature delivered recently, add customMsg for sanity check failures, was causing unexpected sanity_check results. This was due to premature cache key reset of pre_sanity_check_failed and post_sanity_check_failed. Removed those two keys from getting reset before sessionfinish to resolve the issue Type of change Bug fix Testbed and Framework(new/improvement) Test case(new/improvement) Back port request 202012 202205 202305 202311 202405 Approach What is the motivation for this PR? How did you do it? Remove premature cache reset of pre_sanity_check_failed and post_sanity_check_failed, before it reaches sessionfinish How did you verify/test it? Manually tested, simulating pre_sanity_checked_failed and post_sanity_check_failed, to observe expected exit satus codes from 10,11, and 12. Exit status code can be retrieved and displayed, using 'echo $?' eg: image co-authorized by: [email protected]
8 tasks
|
Original PR: #14792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature delivered recently, add customMsg for sanity check failures, was causing unexpected sanity_check results. This was due to premature cache key reset of pre_sanity_check_failed and post_sanity_check_failed. Removed those two keys from getting reset before sessionfinish to resolve the issue
Important cache keys, used to determine session exit status:
pre_sanity_check_failed & post_sanity_check_failed => These combination of keys will return exit status 10, 11, 12
10 = PRE_SANITY_CHECK_FAILED_RC
11 = POST_SANITY_CHECK_FAILED_RC
12 = SANITY_CHECK_FAILED_RC
duthosts_fixture_failed => If this is true, we return exit status code 15
15 = DUTHOSTS_FIXTURE_FAILED_RC
Description of PR
Summary:
New feature delivered recently, add customMsg for sanity check failures, was causing unexpected sanity_check results. This was due to premature cache key reset of pre_sanity_check_failed and post_sanity_check_failed. Removed those two keys from getting reset before sessionfinish to resolve the issue
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
Remove premature cache reset of pre_sanity_check_failed and post_sanity_check_failed, before it reaches sessionfinish
How did you verify/test it?
Manually tested, simulating pre_sanity_checked_failed and post_sanity_check_failed, to observe expected exit satus codes from 10,11, and 12.
Exit status code can be retrieved and displayed, using 'echo $?'
eg:
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation