[action] [PR:14724] [platform_tests/counterpoll]: Don't run counterpoll_watermark test on supervisor #14782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… supervisor (sonic-net#14724) Select only frontend hwskus for counterpoll_queue_watermark_pg_drop test Assert if waiting for COUNTER_DB to be populated fails BugLink: sonic-net#14721 Summary: Fixes sonic-net#14721 Approach What is the motivation for this PR? platform test test_counterpoll_watermark_pg_drop runs and fails on the sup cards, where it should only be running on linecards. Test case fixture needs to be modified to only select frontend cards. Additionally, the test should fail if it fails to wait on the COUNTER_DB on becoming populated How did you do it? How did you verify/test it? Run on testbed - successfully skips supervisor, and asserts properly if the counter_db is not populated Signed-off-by: Liam Kearney <[email protected]>
|
Original PR: #14724 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BugLink: #14721
Summary:
Fixes #14721
Type of change
Back port request
Approach
What is the motivation for this PR?
platform test test_counterpoll_watermark_pg_drop runs and fails on the sup cards, where it should only be running on linecards. Test case fixture needs to be modified to only select frontend cards. Additionally, the test should fail if it fails to wait on the COUNTER_DB on becoming populated
How did you do it?
How did you verify/test it?
Run on testbed - successfully skips supervisor, and asserts properly if the counter_db is not populated
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation