-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[platform_tests/counterpoll]: Support multi-asic for counterpoll watermark tests #14777
base: master
Are you sure you want to change the base?
[platform_tests/counterpoll]: Support multi-asic for counterpoll watermark tests #14777
Conversation
03188f5
to
1e66621
Compare
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
1e66621
to
f89d7e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please test this change on T0/T1 testbed to make sure these changes do not break single ASIC platforms
@arlakshm tested on t0 TB, and a t2 TB with a multi-asic and single-asic linecard - tests pass |
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
…mark tests * Update counterpoll watermark platform test to support multi-asic DUTs * Add show_and_parse() to SonicAsic BugLink: sonic-net#14753 Signed-off-by: Liam Kearney <[email protected]>
4670145
to
6de8ebf
Compare
BugLink: #14753
Description of PR
Refactor test_counterpoll_watermark to properly handle multi-asic DUTs. The previous version of the test would fail on multi-asic as it would not look at the namespaced database containers.
Summary:
Fixes #14753
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix test case to properly run on multi-asic
How did you do it?
How did you verify/test it?
Ran the test on a testbed with multi-asic and single asic devices. Test runs without errors in testplan logic
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation