Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom message for pre/post sanity check results #14755

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

augusdn
Copy link
Contributor

@augusdn augusdn commented Sep 26, 2024

Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use.

Description of PR

Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use.
Summary:
Fixes # (issue)
Add custom message for pre/post sanity check results

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

To enhance debugging by adding extra information into customMsg we already have, and also make it expandable so others can add debugging information to be utlised in ADE

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use.
Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 468294c into sonic-net:master Sep 27, 2024
16 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Sep 27, 2024
Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use.

Description of PR
Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use.

Approach
What is the motivation for this PR?
To enhance debugging by adding extra information into customMsg we already have, and also make it expandable so others can add debugging information to be utlised in ADE

co-authorized by: [email protected]
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #14781

mssonicbld pushed a commit that referenced this pull request Sep 27, 2024
Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use.

Description of PR
Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use.

Approach
What is the motivation for this PR?
To enhance debugging by adding extra information into customMsg we already have, and also make it expandable so others can add debugging information to be utlised in ADE

co-authorized by: [email protected]
arista-hpandya pushed a commit to arista-hpandya/sonic-mgmt that referenced this pull request Oct 2, 2024
Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use.

Description of PR
Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use.

Approach
What is the motivation for this PR?
To enhance debugging by adding extra information into customMsg we already have, and also make it expandable so others can add debugging information to be utlised in ADE

co-authorized by: [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants