-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom message for pre/post sanity check results #14755
Merged
Merged
+64
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yejianquan
reviewed
Sep 26, 2024
yejianquan
reviewed
Sep 26, 2024
cyw233
reviewed
Sep 26, 2024
Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use.
augusdn
force-pushed
the
addCustomMsg
branch
from
September 26, 2024 23:50
bb64365
to
7899f17
Compare
yejianquan
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 27, 2024
Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use. Description of PR Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use. Approach What is the motivation for this PR? To enhance debugging by adding extra information into customMsg we already have, and also make it expandable so others can add debugging information to be utlised in ADE co-authorized by: [email protected]
Cherry-pick PR to 202405: #14781 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Sep 27, 2024
Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use. Description of PR Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use. Approach What is the motivation for this PR? To enhance debugging by adding extra information into customMsg we already have, and also make it expandable so others can add debugging information to be utlised in ADE co-authorized by: [email protected]
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Sep 27, 2024
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use. Description of PR Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use. Approach What is the motivation for this PR? To enhance debugging by adding extra information into customMsg we already have, and also make it expandable so others can add debugging information to be utlised in ADE co-authorized by: [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use.
Description of PR
Expand custom message feature to find potentially risky tests and modify existing custom message to be expandable for future use.
Summary:
Fixes # (issue)
Add custom message for pre/post sanity check results
Type of change
Back port request
Approach
What is the motivation for this PR?
To enhance debugging by adding extra information into customMsg we already have, and also make it expandable so others can add debugging information to be utlised in ADE
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation