[T2] [Chassis] Skip override_config_table_masic test for upstream line card #14713
+27
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjair-git
force-pushed
the
override_config
branch
2 times, most recently
from
97f4275
to
13b0eef
Compare
judyjoseph
previously approved these changes
Oct 1, 2024
judyjoseph
reviewed
Oct 1, 2024
tests/conftest.py
Outdated
| for a_dut in duthosts.frontend_nodes: | ||
| minigraph_facts = a_dut.get_extended_minigraph_facts(tbinfo) | ||
| minigraph_neighbors = minigraph_facts['minigraph_neighbors'] | ||
| if tbinfo["topo"]["type"] == "t0": |
There was a problem hiding this comment.
This can be outside the loop ?
There was a problem hiding this comment.
Hi @judyjoseph, Thanks for reviewing. Corrected the loop now.
Skip override_config_table_masic for upstream LC Remove redundant changes enum_upstream_dut_hostname fixture
sanjair-git
force-pushed
the
override_config
branch
from
13b0eef
to
a1e2a74
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
This PR fixes 'test_override_config_table_masic-test_load_minigraph_with_golden_config' failure on upstream line card on T2 topo Chassis.
The above test fails with the following issue on DEVICE_METADATA table when 'config load_minigraph' is done with empty golden config input.
The test passes on downstream linecards.
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Run 'test_override_config_table_masic-test_load_minigraph_with_golden_config' on T2 chassis and verify the test passes without any issues.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation