Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202405 - cherry pick]: Enhancement of port selection criteria for multidut RDMA cases… #14256

Closed
wants to merge 3 commits into from

Commits on Aug 26, 2024

  1. [Fix]: Enhancement of port selection criteria for multidut RDMA cases…

    … based on testbed informaition (sonic-net#14127)
    
    Description of PR
    Summary: This PR enhances the logic for port selection for multidut RDMA cases based on the conf-name defined in the testbed.csv / testbed.yaml file. And also a generic fixture for single and multidut topology to get the snappi ports, dut port, asic_type, asic_value information
    Fixes # (issue)
    
    Approach
    What is the motivation for this PR?
    For enhancing the port selection logic and a generic fixture for single and multidut topology
    
    How did you do it?
    Added a pytest fixture called get_snappi_ports and get_snappi_ports_for_rdma whcih selects the ports from the information provided in MULTIDUT_PORT_INFO in variables.py and the testbed info as shown below in testbed.csv
    
    vms-snappi-sonic,vms6-1,ptf64,docker-ptf-snappi,snappi-sonic-ptf,10.36.78.59,,Server_6,,sonic-s6100-dut1,snappi-sonic,True,Batman
    vms-snappi-sonic-multidut,vms6-1,ptf64,docker-ptf-snappi,snappi-sonic-ptf,10.36.78.59,,Server_6,,[sonic-s6100-dut1;sonic-s6100-dut2],snappi-sonic,True,Batman
    vms-snappi-single-dut-multi-asic,vms6-1,ptf64,docker-ptf-snappi,snappi-sonic-ptf,10.36.78.59,,Server_6,,sonic-s6100-dut1,snappi-sonic,True,Batman
    vms-snappi-multi-dut-multi-asic,vms6-1,ptf64,docker-ptf-snappi,snappi-sonic-ptf,10.36.78.59,,Server_6,,[sonic-s6100-dut1;sonic-s6100-dut2],snappi-sonic,True,Batman
    How did you verify/test it?
    Tested the logic on pfc cases
    
    co-authorized by: [email protected]
    selldinesh committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    5502076 View commit details
    Browse the repository at this point in the history
  2. [Fix]: Enhancement of port selection criteria for multidut RDMA cases…

    … based on testbed informaition (sonic-net#14127)
    
    Description of PR
    Summary: This PR enhances the logic for port selection for multidut RDMA cases based on the conf-name defined in the testbed.csv / testbed.yaml file. And also a generic fixture for single and multidut topology to get the snappi ports, dut port, asic_type, asic_value information
    Fixes # (issue)
    
    Approach
    What is the motivation for this PR?
    For enhancing the port selection logic and a generic fixture for single and multidut topology
    
    How did you do it?
    Added a pytest fixture called get_snappi_ports and get_snappi_ports_for_rdma whcih selects the ports from the information provided in MULTIDUT_PORT_INFO in variables.py and the testbed info as shown below in testbed.csv
    
    vms-snappi-sonic,vms6-1,ptf64,docker-ptf-snappi,snappi-sonic-ptf,10.36.78.59,,Server_6,,sonic-s6100-dut1,snappi-sonic,True,Batman
    vms-snappi-sonic-multidut,vms6-1,ptf64,docker-ptf-snappi,snappi-sonic-ptf,10.36.78.59,,Server_6,,[sonic-s6100-dut1;sonic-s6100-dut2],snappi-sonic,True,Batman
    vms-snappi-single-dut-multi-asic,vms6-1,ptf64,docker-ptf-snappi,snappi-sonic-ptf,10.36.78.59,,Server_6,,sonic-s6100-dut1,snappi-sonic,True,Batman
    vms-snappi-multi-dut-multi-asic,vms6-1,ptf64,docker-ptf-snappi,snappi-sonic-ptf,10.36.78.59,,Server_6,,[sonic-s6100-dut1;sonic-s6100-dut2],snappi-sonic,True,Batman
    How did you verify/test it?
    Tested the logic on pfc cases
    
    co-authorized by: [email protected]
    selldinesh committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    2f338e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. fixing pre-commit errors

    selldinesh committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    ab3a3be View commit details
    Browse the repository at this point in the history