[QoS]Test_buffer_model test skip for Nokia platform #13690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlakshm
previously approved these changes
Sep 3, 2024
| @@ -1166,7 +1166,7 @@ qos/test_buffer.py::test_buffer_model_test: | |||
| skip: | |||
| reason: "Running only on mellanox devices and covered by unit testing" | |||
| conditions: | |||
| - "asic_type in ['mellanox']" | |||
| - "asic_type in ['mellanox'] or platform in ['x86_64-nokia_ixr7250e_36x400g-r0']" | |||
There was a problem hiding this comment.
is this an asic limitation? can we add asic_subtype == 'dnx' iso of platform check?
ansrajpu-git
changed the title
|
@arlakshm , updated condition. please approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Updating skip condition for test_buffer_model_test.py in conditional mark as this was overriding the base test skip condition for nokia platform 'x86_64-nokia_ixr7250e_36x400g-r0'
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Test suite was executing skipped test.
How did you do it?
Updated the conditional mark skip condition
How did you verify/test it?
Executed the test and verify the results
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation