Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Winbond flash devices that could not parse SFDP #436

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vivekrnv
Copy link
Contributor

the following errors are seen on one of our system with w25q128 flash

sonic kernel: [    5.814911] spi-nor spi0.0: BFPT parsing failed. Please consider using SPI_NOR_SKIP_SFDP when declaring the flash
sonic kernel: [    5.934937] spi-nor: probe of spi0.0 failed with error -524

In 5.10, i see the following:

[    4.851862] intel-spi intel-spi: w25q128 (16384 Kbytes)
[    4.928908] Creating 1 MTD partitions on "intel-spi":

This is reported elsewhere: https://lore.kernel.org/all/[email protected]/T/ and the fix for this is merged in upstream gregkh/linux@d35df77 but the backport is not present in the stable versions.

Until that is backported, the offending commit is reverted

Copy link
Contributor

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the following errors are seen on one of our system with w25q128 flash

Which one?

Why not add the patch from the Linux master branch instead of reverting the commit?

@vivekrnv
Copy link
Contributor Author

msn2100 platform. upstream code is refactored and patch cannot be applied directly. gregkh/linux@d35df77.

It seems safe to revert the offending commit than to make an effort to port the upstream change into the stable branch.

I'll ofcourse change this once the upstream commit is backported to 6.1 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants