Add enable_xcvrd_sff_mgr flag support for xcvrd startup command

[longhuan-cisco]

This PR is a dependency of sonic-net/sonic-platform-daemons#383
HLD of sff_mgr: sonic-net/SONiC#1371

Why I did it

Add enable_xcvrd_sff_mgr flag support for sff_mgr

Work item tracking

• Microsoft ADO (number only):

How I did it

In docker-pmon.supervisord.conf.j2 file, add logic to append enable_sff_mgr flag to xcvrd startup command based on the enable_xcvrd_sff_mgr flag defined in pmon_daemon_control.json

Also did clean-up on the corresponding j2 logic to make it more read-able and easier to extend.

How to verify it

Verified with different combinations of flags for the output of j2, matched with the original and correct output.

sonic-cfggen -a '{"skip_xcvrd_cmis_mgr": false, "enable_xcvrd_sff_mgr": false, "delay_xcvrd": false}' -t /usr/share/sonic/templates/docker-pmon.supervisord.conf.j2 | grep "program:xcvrd" -A 1
[program:xcvrd]
command=python3 /usr/local/bin/xcvrd

sonic-cfggen -a '{"skip_xcvrd_cmis_mgr": true, "enable_xcvrd_sff_mgr": false, "delay_xcvrd": false}' -t /usr/share/sonic/templates/docker-pmon.supervisord.conf.j2 | grep "program:xcvrd" -A 1
[program:xcvrd]
command=python3 /usr/local/bin/xcvrd --skip_cmis_mgr

sonic-cfggen -a '{"skip_xcvrd_cmis_mgr": false, "enable_xcvrd_sff_mgr": true, "delay_xcvrd": false}' -t /usr/share/sonic/templates/docker-pmon.supervisord.conf.j2 | grep "program:xcvrd" -A 1
[program:xcvrd]
command=python3 /usr/local/bin/xcvrd --enable_sff_mgr

sonic-cfggen -a '{"skip_xcvrd_cmis_mgr": false, "enable_xcvrd_sff_mgr": false, "delay_xcvrd": true}' -t /usr/share/sonic/templates/docker-pmon.supervisord.conf.j2 | grep "program:xcvrd" -A 1
[program:xcvrd]
command=bash -c "sleep 30 && python3 /usr/local/bin/xcvrd"

sonic-cfggen -a '{"skip_xcvrd_cmis_mgr": true, "enable_xcvrd_sff_mgr": true, "delay_xcvrd": false}' -t /usr/share/sonic/templates/docker-pmon.supervisord.conf.j2 | grep "program:xcvrd" -A 1
[program:xcvrd]
command=python3 /usr/local/bin/xcvrd --skip_cmis_mgr --enable_sff_mgr

sonic-cfggen -a '{"skip_xcvrd_cmis_mgr": true, "enable_xcvrd_sff_mgr": false, "delay_xcvrd": true}' -t /usr/share/sonic/templates/docker-pmon.supervisord.conf.j2 | grep "program:xcvrd" -A 1
[program:xcvrd]
command=bash -c "sleep 30 && python3 /usr/local/bin/xcvrd --skip_cmis_mgr"

sonic-cfggen -a '{"skip_xcvrd_cmis_mgr": false, "enable_xcvrd_sff_mgr": true, "delay_xcvrd": true}' -t /usr/share/sonic/templates/docker-pmon.supervisord.conf.j2 | grep "program:xcvrd" -A 1
[program:xcvrd]
command=bash -c "sleep 30 && python3 /usr/local/bin/xcvrd --enable_sff_mgr"

sonic-cfggen -a '{"skip_xcvrd_cmis_mgr": true, "enable_xcvrd_sff_mgr": true, "delay_xcvrd": true}' -t /usr/share/sonic/templates/docker-pmon.supervisord.conf.j2 | grep "program:xcvrd" -A 1
[program:xcvrd]
command=bash -c "sleep 30 && python3 /usr/local/bin/xcvrd --skip_cmis_mgr --enable_sff_mgr"

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012
• 202106
• 202111
• 202205
• 202211
• 202305

Tested branch (Please provide the tested image version)

• 202305

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

[prgeor]

@longhuan-cisco please add the link to HLD in PR description

[longhuan-cisco]

@longhuan-cisco please add the link to HLD in PR description

@prgeor sure added on both sides.

[prgeor]

@longhuan-cisco nice refactoring. thanks.

[prgeor]

@rlhui @lguohan can you help merge

[longhuan-cisco]

@rlhui @lguohan can you help merge

@rlhui @lguohan could you please help on the merge?
This PR is needed to enable sff_mgr (whose PR was already merged).