Skip to content

Commit

Permalink
[doc] fix image links for buffer watermark (#608)
Browse files Browse the repository at this point in the history
Signed-off-by: Mykola Faryma <[email protected]>
  • Loading branch information
mykolaf authored Apr 22, 2020
1 parent b71c252 commit c087302
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions doc/buffer-watermark/watermarks_HLD.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ This document describes the high level design of the watermark feature.
## 1.1 System Chart
Following diagram describes a top level overview of the architecture:

![](https://github.com/mykolaf/SONiC/blob/master/images/watermark_HLD/SystemOverview.png)
![](https://github.com/Azure/SONiC/blob/master/images/watermark_HLD/SystemOverview.png)

## 1.2 Modules description
### 1.2.1 gRPC
Expand Down Expand Up @@ -102,7 +102,7 @@ Regular user is able to query the persistent watermark. Regular user is able to

When one regular user and the streaming telemetry coexist, they do not interfere with each other. Their behaviors stay the same as described above. So the software should be able to handle the following situations and return the correct watermark values to each user:

![](https://github.com/mykolaf/SONiC/blob/master/images/watermark_HLD/timeline2.png)
![](https://github.com/Azure/SONiC/blob/master/images/watermark_HLD/timeline.png)


t0 - clear user watermark event
Expand Down Expand Up @@ -337,7 +337,7 @@ Examples of virtual paths:

#### 4.1 Watermark general flow

![](https://github.com/mykolaf/SONiC/blob/master/images/watermark_HLD/WM_general.png)
![](https://github.com/Azure/SONiC/blob/master/images/watermark_HLD/WM_general.png)

The core components are the flex counter, watermark orch, DB, CLI.

Expand All @@ -353,13 +353,13 @@ The Cli reads the watermarks from the tables, formats and outputs it.

#### 4.2 Resetting the telemetry period flow

![](https://github.com/mykolaf/SONiC/blob/master/images/watermark_HLD/WM_period.PNG)
![](https://github.com/Azure/SONiC/blob/master/images/watermark_HLD/WM_period.PNG)

The watermark orch handles notifications on changes in WATERMARK_TABLE in config DB. The new interval will be assigned to the timer during the timer handling, so the orch will reset the interval only when the current timer expires.

#### 4.3 Cli flow

![](https://github.com/mykolaf/SONiC/blob/master/images/watermark_HLD/WM_cli.png)
![](https://github.com/Azure/SONiC/blob/master/images/watermark_HLD/WM_cli.png)

### 5 Open questions

Expand Down
Binary file added images/watermark_HLD/WM_cli.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/watermark_HLD/WM_general.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/watermark_HLD/WM_period.PNG
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit c087302

Please sign in to comment.