-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Fast Path ICMP flow redirection updates #666
base: main
Are you sure you want to change the base?
Conversation
/azp run |
Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH |
/azp run |
Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH |
/azp run |
Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH |
/azp run |
Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH |
/azp run |
Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH |
/azp run |
Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH |
hi @devenjagasia , I am seeing this PR is in draft state and there are some CI failures as well. Please let me know, once it is ready for review! : D |
documentation/load-bal-service/fast-path-icmp-flow-redirection.md
Outdated
Show resolved
Hide resolved
documentation/load-bal-service/fast-path-icmp-flow-redirection.md
Outdated
Show resolved
Hide resolved
documentation/load-bal-service/fast-path-icmp-flow-redirection.md
Outdated
Show resolved
Hide resolved
documentation/load-bal-service/fast-path-icmp-flow-redirection.md
Outdated
Show resolved
Hide resolved
documentation/load-bal-service/fast-path-icmp-flow-redirection.md
Outdated
Show resolved
Hide resolved
The ICMPv6 Redirect packet enriched with the Redirect option serves the same purpose for ipv6 scenarios: | ||
``` | ||
0 1 2 3 | ||
0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a mermaid graph to show the packet format, it will be much easier to write this using that.
|
||
 | ||
|
||
## PE / ST Scenario |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit concerned on this one, and will be great to get it confirmed. With this design, icmpv6 redirect will be tied to PE and ST, and cannot be used by other scenarios. Not sure how this would affect IPv6 VIP and etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I made the setting name generic to address this: SAI_ENI_ATTR_DISABLE_FAST_PATH_ICMPV6_FLOW_REDIRECTION,
Let me know if this works
/azp run |
Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH |
/azp run |
Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH |
/azp run |
Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH |
/azp run |
Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH |
/azp run |
Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH |
/azp run |
Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH |
/azp run |
Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH |
The pre-commit check detected issues in the files touched by this pull request. |
/azp run |
Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH |
The pre-commit check detected issues in the files touched by this pull request. |
/azp run |
Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH |
The pre-commit check detected issues in the files touched by this pull request. |
|
||
There should be 3 knobs for controlling the 3 individual scenarios mentioned above. | ||
1. vip / ilpip fastpath toggle - if enabled, honor ipv4 redirect with gre key 253 | ||
1. ST / PE fastpath toggle - if enabled, honor ipv6 redirect packet with gre key 254 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe better to call it ST / PE / V6 fast path toggle.
thanks a lot Deven for addressing the comments! |
No description provided.