Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fast Path ICMP flow redirection updates #666

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

devenjagasia
Copy link
Collaborator

No description provided.

@mssonicbld
Copy link

/azp run

Copy link

linux-foundation-easycla bot commented Feb 8, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH

@mssonicbld
Copy link

/azp run

Copy link

Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH

@mssonicbld
Copy link

/azp run

Copy link

Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH

@mssonicbld
Copy link

/azp run

Copy link

Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH

@mssonicbld
Copy link

/azp run

Copy link

Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH

@mssonicbld
Copy link

/azp run

Copy link

Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH

@r12f
Copy link
Collaborator

r12f commented Feb 10, 2025

hi @devenjagasia , I am seeing this PR is in draft state and there are some CI failures as well. Please let me know, once it is ready for review! : D

The ICMPv6 Redirect packet enriched with the Redirect option serves the same purpose for ipv6 scenarios:
```
0 1 2 3
0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a mermaid graph to show the packet format, it will be much easier to write this using that.


![after-ICMP-redirect](images/vip-tx-after-redirect.png)

## PE / ST Scenario
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit concerned on this one, and will be great to get it confirmed. With this design, icmpv6 redirect will be tied to PE and ST, and cannot be used by other scenarios. Not sure how this would affect IPv6 VIP and etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I made the setting name generic to address this: SAI_ENI_ATTR_DISABLE_FAST_PATH_ICMPV6_FLOW_REDIRECTION,

Let me know if this works

@mssonicbld
Copy link

/azp run

Copy link

Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH

@mssonicbld
Copy link

/azp run

Copy link

Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH

@mssonicbld
Copy link

/azp run

Copy link

Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH

@mssonicbld
Copy link

/azp run

Copy link

Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH

@mssonicbld
Copy link

/azp run

Copy link

Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH

@mssonicbld
Copy link

/azp run

Copy link

Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH

@mssonicbld
Copy link

/azp run

Copy link

Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH

Copy link

The pre-commit check detected issues in the files touched by this pull request.

Detailed pre-commit check results:

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [WARNING] repo https://github.com/pre-commit/pre-commit-hooks uses deprecated stage names (commit, push) which will be removed in a future version. Hint: often pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks will fix this. if it does not -- consider reporting an issue to that repo. [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... mixed line ending........................................................Failed - hook id: mixed-line-ending - exit code: 1 - files were modified by this hook documentation/load-bal-service/fast-path-icmp-flow-redirection.md: fixed mixed line endings
To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3.

2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder

4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>
or
pre-commit run --all-files

@mssonicbld
Copy link

/azp run

Copy link

Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH

Copy link

The pre-commit check detected issues in the files touched by this pull request.

Detailed pre-commit check results:

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [WARNING] repo https://github.com/pre-commit/pre-commit-hooks uses deprecated stage names (commit, push) which will be removed in a future version. Hint: often pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks will fix this. if it does not -- consider reporting an issue to that repo. [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... mixed line ending........................................................Failed - hook id: mixed-line-ending - exit code: 1 - files were modified by this hook documentation/load-bal-service/fast-path-icmp-flow-redirection.md: fixed mixed line endings
To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3.

2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder

4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>
or
pre-commit run --all-files

@mssonicbld
Copy link

/azp run

Copy link

Commenter does not have sufficient privileges for PR 666 in repo sonic-net/DASH

Copy link

The pre-commit check detected issues in the files touched by this pull request.

Detailed pre-commit check results:

[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [WARNING] repo https://github.com/pre-commit/pre-commit-hooks uses deprecated stage names (commit, push) which will be removed in a future version. Hint: often pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks will fix this. if it does not -- consider reporting an issue to that repo. [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... mixed line ending........................................................Failed - hook id: mixed-line-ending - exit code: 1 - files were modified by this hook documentation/load-bal-service/fast-path-icmp-flow-redirection.md: fixed mixed line endings
To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3.

2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder

4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>
or
pre-commit run --all-files


There should be 3 knobs for controlling the 3 individual scenarios mentioned above.
1. vip / ilpip fastpath toggle - if enabled, honor ipv4 redirect with gre key 253
1. ST / PE fastpath toggle - if enabled, honor ipv6 redirect packet with gre key 254
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better to call it ST / PE / V6 fast path toggle.

@r12f
Copy link
Collaborator

r12f commented Feb 19, 2025

thanks a lot Deven for addressing the comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants