Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update saic to latest master to include fix for import asic module issue. #637

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

vikumarks
Copy link
Contributor

Update saic to latest to get "Fix import asic module issue. #240"

@vikumarks vikumarks changed the title Update saic to latest to include fix for import asic module issue. Update saic to latest master to include fix for import asic module issue. Oct 30, 2024
@vikumarks
Copy link
Contributor Author

@r12f can you please review and merge if it looks good to you.
I am trying to enable saic test cases and getting some error
`_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/usr/local/lib/python3.9/dist-packages/saichallenger/common/sai_testbed.py:217: in init
self.spawn()
/usr/local/lib/python3.9/dist-packages/saichallenger/common/sai_testbed.py:197: in spawn
asic = self.spawn_asic(self.base_dir, dpu_cfg, "dpu")
/usr/local/lib/python3.9/dist-packages/saichallenger/common/sai_testbed.py:152: in spawn_asic
asic = SaiDpu(params)
/usr/local/lib/python3.9/dist-packages/saichallenger/common/sai_dpu.py:11: in init
super().init(cfg)
/usr/local/lib/python3.9/dist-packages/saichallenger/common/sai.py:186: in init
self.sai_client = SaiClient.spawn(cfg["client"])
/usr/local/lib/python3.9/dist-packages/saichallenger/common/sai_client/sai_client.py:101: in spawn
from sai_client.sai_thrift_client.sai_thrift_client import SaiThriftClient
/usr/local/lib/python3.9/dist-packages/saichallenger/common/sai_client/sai_thrift_client/sai_thrift_client.py:8: in
from saichallenger.common.sai_client.sai_thrift_client.sai_thrift_utils import *


`
And looks like its fixed by below PR submitted and merged to SAI-Challenger
opencomputeproject/SAI-Challenger#240

@r12f r12f merged commit 01260d4 into sonic-net:main Oct 31, 2024
2 checks passed
@vikumarks vikumarks deleted the pr-update-saic-to-latest branch October 31, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants