[16.0][MIG] account_payment_mode_auto_reconcile: Migrate to version 16.0 #6

sonhd91 · 2023-03-08T12:56:36Z

No description provided.

sonhd91 · 2023-03-08T14:21:41Z

account_payment_mode_auto_reconcile/models/account_move.py

                    continue
-                payment_mode = invoice.payment_mode_id
+                invoice_lines = invoice.line_ids


account.invoice removed use account.move instead. Since payment_mode_id computed by filtered out lines with existed credits/debit, so we use the same that logic in line 57

sonhd91

Change noted

sonhd91 · 2023-03-08T14:45:39Z

account_payment_mode_auto_reconcile/models/account_move.py

+
+    def write(self, vals):
+        res = super(AccountMove, self).write(vals)
+        if "payment_mode_id" in vals or "state" in vals:


In Odoo16, only invoice with posted status would list potential payments can be reconciled, so we only auto reconciled after posting the invoice, draft invoice will remove existing reconciled payment

sonhd91 · 2023-03-08T14:58:27Z

account_payment_mode_auto_reconcile/tests/test_partner_auto_reconcile.py

+        )
+        auto_rec_invoice.action_post()
+        self.assertTrue(self.payment_mode.auto_reconcile_outstanding_credits)
+        self.assertEqual(self.invoice_copy.amount_residual, 1615.5)


amount_residual now include the tax_price, so we recal amount_residual

lehoangan · 2023-03-10T02:55:44Z

account_payment_mode_auto_reconcile/models/account_move.py

-        res = super(AccountInvoice, self).invoice_validate()
-        for invoice in self:
-            if invoice.type != "out_invoice":
+    @api.model_create_multi


I think you should override action_post

lehoangan · 2023-03-10T03:04:43Z

account_payment_mode_auto_reconcile/models/account_move.py

                    continue
-                payment_mode = invoice.payment_mode_id
+                invoice_lines = invoice.line_ids


invoice.line_ids only get receivable lines

lehoangan · 2023-03-10T03:37:54Z

account_payment_mode_auto_reconcile/models/account_move.py

+                    self.env["account.payment"]
+                    .browse(payment.get("account_payment_id"))
+                    .line_ids
+                )


Why did you add () here?

lehoangan · 2023-03-10T03:43:21Z

account_payment_mode_auto_reconcile/models/account_move.py

+                    invoice.line_ids.mapped("matched_debit_ids"),
+                ]
+            )
+            if invoice.move_type != "out_invoice" or invoice.state == "posted":


invoice.state == "paid" -> invoice.state == "posted" is wrong. Plz check payment_state

lehoangan · 2023-03-10T03:44:25Z

account_payment_mode_auto_reconcile/models/account_move.py

                invoice.payment_mode_warning = ""
                invoice.display_payment_mode_warning = False
                continue
            invoice.display_payment_mode_warning = True
            if (
-                invoice.state != "open"
+                invoice.state != "draft"


invoice.state != "open" should be invoice.state == 'posted' and payment_state != 'paid'

Still not update

lehoangan · 2023-03-10T03:45:23Z

account_payment_mode_auto_reconcile/models/account_move.py

@@ -125,8 +142,8 @@ def _compute_payment_mode_warning(self):
                    " any outstanding credits."
                )
            elif (
-                invoice.state == "open"
-                and invoice.payment_move_line_ids
+                invoice.state == "draft"


invoice.state == "draft" is wrong

lehoangan · 2023-03-10T03:45:55Z

account_payment_mode_auto_reconcile/models/account_move.py

@@ -137,11 +154,11 @@ def _compute_payment_mode_warning(self):
                    "reconciled payments."
                )
            elif (
-                invoice.state == "open"
-                and not invoice.payment_move_line_ids
+                invoice.state == "draft"


invoice.state == "draft" is wrong

lehoangan · 2023-03-10T03:49:27Z

account_payment_mode_auto_reconcile/readme/DESCRIPTION.rst

@@ -4,8 +4,8 @@ checked.

 Automatic reconciliation of outstanding credits will only happen on customer
 invoices at validation if the payment mode is set or when the payment mode is
-changed on an open invoice. If a payment mode using auto-reconcile is removed
-from an open invoice, the existing auto reconciled payments will be removed.
+changed on an draft invoice. If a payment mode using auto-reconcile is removed


plz keep open

lehoangan · 2023-03-10T05:35:00Z

account_payment_mode_auto_reconcile/models/account_move.py

+            )
+            if (
+                invoice.move_type != "out_invoice"
+                or invoice.state == "posted"


it should be or ( invoice.state == "posted" and invoice.payment_state != "paid")

lehoangan · 2023-03-10T05:35:24Z

account_payment_mode_auto_reconcile/models/account_move.py

                invoice.payment_mode_warning = ""
                invoice.display_payment_mode_warning = False
                continue
            invoice.display_payment_mode_warning = True
            if (
-                invoice.state != "open"
+                invoice.state != "draft"


Still not update

lehoangan

LGTM

Override write instead of using onchange Add missing utf-8 comment Fix warning message Restrict to customer invoices Add readme and load tests Improvements after reviews Improve doc Unreconcile only automatically reconciled payments

* Add auto reconcile only same journal Add an option to auto reconcile only credits that are on the same journal than the invoice. This make sure that unrelated payment will not be used automatically. * Update account_payment_mode_auto_reconcile/models/account_invoice.py Co-Authored-By: Akim Juillerat <[email protected]> * Update account_payment_mode_auto_reconcile/tests/test_partner_auto_reconcile.py Co-Authored-By: Akim Juillerat <[email protected]>

This small change is needed since action_invoice_open filters invoices that can be open from other invoices that cannot. Therefore using invoice_validate here allows for better customizations by ensuring that the invoices to be handled are really open (i.e. have a move generated).

As using reverse is not reliable to ensure oldest credits will be reconciled first, use a function to sort the dicts according to their id and allows inheritance.

sonhd91 force-pushed the 16.0-mig-account_payment_mode_auto_reconcile branch from be43eb9 to 5e696bb Compare March 8, 2023 14:18

sonhd91 commented Mar 8, 2023

View reviewed changes

sonhd91 force-pushed the 16.0-mig-account_payment_mode_auto_reconcile branch 4 times, most recently from 8e36546 to ba9b11e Compare March 9, 2023 02:36

lehoangan reviewed Mar 10, 2023

View reviewed changes

sonhd91 force-pushed the 16.0-mig-account_payment_mode_auto_reconcile branch from ba9b11e to 8ebff3f Compare March 10, 2023 05:23

lehoangan reviewed Mar 10, 2023

View reviewed changes

sonhd91 force-pushed the 16.0-mig-account_payment_mode_auto_reconcile branch from 8ebff3f to 00341af Compare March 10, 2023 06:12

lehoangan approved these changes Mar 10, 2023

View reviewed changes

sonhd91 force-pushed the 16.0-mig-account_payment_mode_auto_reconcile branch 2 times, most recently from f440e10 to e97a4aa Compare June 15, 2023 06:15

grindtildeath and others added 8 commits May 6, 2024 10:36

Add account_payment_mode_auto_reconcile

23b5931

Override write instead of using onchange Add missing utf-8 comment Fix warning message Restrict to customer invoices Add readme and load tests Improvements after reviews Improve doc Unreconcile only automatically reconciled payments

[FIX] typo in variable name

469a393

FIX: Use function to sort credits

70037fd

As using reverse is not reliable to ensure oldest credits will be reconciled first, use a function to sort the dicts according to their id and allows inheritance.

[ADD] icon.png

f4f22b1

[IMP] account_payment_mode_auto_reconcile: black, isort, prettier

11c853d

[16.0][MIG]account_payment_mode_auto_reconcile: Migrate to version 16.0

17386a6

sonhd91 force-pushed the 16.0-mig-account_payment_mode_auto_reconcile branch from e97a4aa to 17386a6 Compare May 6, 2024 03:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] account_payment_mode_auto_reconcile: Migrate to version 16.0 #6

[16.0][MIG] account_payment_mode_auto_reconcile: Migrate to version 16.0 #6

sonhd91 commented Mar 8, 2023

sonhd91 Mar 8, 2023 •

edited

Loading

sonhd91 left a comment

sonhd91 Mar 8, 2023 •

edited

Loading

sonhd91 Mar 8, 2023 •

edited

Loading

lehoangan Mar 10, 2023

lehoangan Mar 10, 2023

lehoangan Mar 10, 2023

lehoangan Mar 10, 2023

lehoangan Mar 10, 2023

lehoangan Mar 10, 2023

lehoangan Mar 10, 2023

lehoangan Mar 10, 2023

lehoangan Mar 10, 2023

lehoangan Mar 10, 2023

lehoangan Mar 10, 2023

lehoangan left a comment

[16.0][MIG] account_payment_mode_auto_reconcile: Migrate to version 16.0 #6

Are you sure you want to change the base?

[16.0][MIG] account_payment_mode_auto_reconcile: Migrate to version 16.0 #6

Conversation

sonhd91 commented Mar 8, 2023

sonhd91 Mar 8, 2023 • edited Loading

Choose a reason for hiding this comment

sonhd91 left a comment

Choose a reason for hiding this comment

sonhd91 Mar 8, 2023 • edited Loading

Choose a reason for hiding this comment

sonhd91 Mar 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lehoangan left a comment

Choose a reason for hiding this comment

sonhd91 Mar 8, 2023 •

edited

Loading

sonhd91 Mar 8, 2023 •

edited

Loading

sonhd91 Mar 8, 2023 •

edited

Loading