fix: check GitHubClientId before enable GitHub OAuth

songquanpeng · Oct 30, 2022 · 70d21b8 · 70d21b8
1 parent 2899649
commit 70d21b8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/common/constants.go b/common/constants.go
@@ -24,7 +24,7 @@ var ItemsPerPage = 10
 var PasswordLoginEnabled = true
 var RegisterEnabled = true
 var EmailVerificationEnabled = false
-var GitHubOAuthEnabled = true
+var GitHubOAuthEnabled = false
 
 var SMTPServer = ""
 var SMTPAccount = ""

diff --git a/controller/option.go b/controller/option.go
@@ -39,6 +39,13 @@ func UpdateOption(c *gin.Context) {
 		})
 		return
 	}
+	if option.Key == "GitHubOAuthEnabled" && option.Value == "true" && common.GitHubClientId == "" {
+		c.JSON(http.StatusOK, gin.H{
+			"success": false,
+			"message": "无法启用 GitHub OAuth，请先填入 GitHub Client ID 以及 GitHub Client Secret！",
+		})
+		return
+	}
 	err = model.UpdateOption(option.Key, option.Value)
 	if err != nil {
 		c.JSON(http.StatusOK, gin.H{