Fix external dns, ingress tls certs #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Readme updates coming shortly |
bobotimi
force-pushed
the
NEXUS-43951-docker-subdomain-issues
branch
from
547e523 to
4548bdf
Compare
Devleooper
reviewed
Dec 2, 2024
| @@ -169,6 +169,97 @@ AWS Secret Manager is disabled by default. If you would like to store your datab | |||
| - You'll need an IAM role with necessary permissions and associate that IAM role with the service account used by your pods: | |||
| - See [External secrets operator EKS service account credentials](https://external-secrets.io/latest/provider/aws-secrets-manager/#eks-service-account-credentials) for more details. | |||
|
|
|||
| ##### Cert-Manager Configuration | |||
There was a problem hiding this comment.
idk if this is only in github preview but it is broken, the table seems to cut at some point and I can see the raw table data instead of the preview, probably a formatting issue?
There was a problem hiding this comment.
After checking , it seems like there is a line break in the table section (line 915), probably needs to get fixed
Devleooper
reviewed
Dec 2, 2024
Devleooper
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed external dns for AWS - external dns service account was not being created in the correct namespace
Added templates for requesting certificates (via CertManager and LetsEncrypt) for domains specified on Ingresses (tested for Azure and AWS