Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST endpoint for get repository #62

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

astoltz
Copy link

@astoltz astoltz commented Feb 4, 2020

There is currently only a REST endpoint to fetch all repositories, not one to get just a single known endpoint. This is useful for Desired State Configuration such as Terraform, Ansible, Chef, etc.

@dawidsawa
Copy link

As with your other PR, we need you first to sign our CLA before we can proceed.

@astoltz
Copy link
Author

astoltz commented Feb 8, 2020

The build failure doesn't look related to anything I touched.

@dawidsawa
Copy link

You're right. It seems like we had a couple more failed builds cause by some issue with PhatomJS over last weekend. I've kicked a re-run for your branch. Thanks for adding a unit test, but I'd kindly like to ask if you could add a functional test that verifies permissions checks as this is an external facing API - there's already a test for the 'fetch all repositories' endpoint in org.sonatype.nexus.testsuite.rest.RepositoriesApiResourceGetMember

@dawidsawa
Copy link

We fixed CircleCI build system yesterday, but the fix is only in our internal repository for now. It should get synchronised to this nexus-public repository over this coming weekend. We hope this didn't discourage you from contributing.

@joedragons
Copy link

Sounds like this could fulfill https://issues.sonatype.org/browse/NEXUS-23757. I will make a note in that ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants