remove failed s3 blobstores #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nection is established
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current version of the implementation it is impossible to delete an existing S3 blobstore, as soon as the AWS token expired. If you are running into this situation you only see the
TokenExpiredException in the logs.
In this PR, we allow the
deleteandforceDeleteto be called forFailedblobstores. Then the S3 blobstore implementation tries to delete the files in the S3 Bucket. This fails with anAmazonS3Exceptionwith error codeExpiredToken. If we simply print the warning message, instead of passing the exception to the top, we can still remove the S3 blobstore.resolves https://github.com/sonatype/nexus-blobstore-s3/issues/62