Makes the TemplateBoxNode yield ready #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twig 3.9 introduces a new "yield" mode in which all Node implementations should be flagged with `#[YieldReady]` once they've been made ready for "yield". See the changelog of twig.
|
Hi @JanStorm Thanks for the PR. Can you run the linter to fix (unrelated) cs errors ? Thanks |
php-cs-fixer changed their ruleset and therefore new linting issues occurred
|
yes of course, done! |
VincentLanglet
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Twig 3.9 introduces a new "yield" mode in which all Node implementations should be flagged with
#[YieldReady]once they've been made ready for "yield".See https://github.com/twigphp/Twig/blob/3.x/CHANGELOG
For example, this has already been implemented in the symfony twig-bridge bundle: symfony/twig-bridge@14a73aa
I am targeting this branch, because its a non-breaking change, which solves a current twig deprecation since twig 3.9.
Changelog