Avoid Username/Email is passed as clear GET Parameter to CheckEmailAction on password reset process #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove usage as discussed in #1692 (comment)
Remove passing username as get Parameter to sonata_user_admin_resetting_check_email as discussed in #1692 (comment)
VincentLanglet
force-pushed
the
check-email
branch
2 times, most recently
from
1c3b8e3
to
3df6e20
Compare
VincentLanglet
force-pushed
the
check-email
branch
from
3df6e20
to
196a602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Avoid Username/Email is passed as clear GET Parameter to CheckEmailAction on password reset process as discussed in #1692
I am targeting this branch, because this fixes an privacy issue and doesn't break anything.
Closes #1692.
Changelog