Run rector

src/Builder/DatagridBuilder.php

@@ -38,10 +38,10 @@
 final class DatagridBuilder implements DatagridBuilderInterface
 {
     public function __construct(
-        private FormFactoryInterface $formFactory,
-        private FilterFactoryInterface $filterFactory,
-        private TypeGuesserInterface $guesser,
-        private bool $csrfTokenEnabled = true,
+        private readonly FormFactoryInterface $formFactory,
+        private readonly FilterFactoryInterface $filterFactory,
+        private readonly TypeGuesserInterface $guesser,
+        private readonly bool $csrfTokenEnabled = true,
     ) {
     }
 

src/Builder/ListBuilder.php

@@ -29,7 +29,7 @@ final class ListBuilder implements ListBuilderInterface
      * @param string[] $templates
      */
     public function __construct(
-        private TypeGuesserInterface $guesser,
+        private readonly TypeGuesserInterface $guesser,
         private array $templates = [],
     ) {
     }

src/Builder/ShowBuilder.php

@@ -29,7 +29,7 @@ final class ShowBuilder implements ShowBuilderInterface
      * @param string[] $templates
      */
     public function __construct(
-        private TypeGuesserInterface $guesser,
+        private readonly TypeGuesserInterface $guesser,
         private array $templates,
     ) {
     }

src/FieldDescription/FieldDescriptionFactory.php

@@ -21,7 +21,7 @@
 
 final class FieldDescriptionFactory implements FieldDescriptionFactoryInterface
 {
-    public function __construct(private ManagerRegistry $registry)
+    public function __construct(private readonly ManagerRegistry $registry)
     {
     }
 

src/Filter/StringFilter.php

@@ -55,7 +55,7 @@ protected function filter(ProxyQueryInterface $query, string $field, FilterData
             return;
         }
 
-        $value = trim($data->getValue());
+        $value = trim((string) $data->getValue());
 
         if ('' === $value) {
             return;

src/Model/ModelManager.php

@@ -42,8 +42,8 @@ final class ModelManager implements ModelManagerInterface, ProxyResolverInterfac
     private const BATCH_SIZE = 20;
 
     public function __construct(
-        private ManagerRegistry $registry,
-        private PropertyAccessorInterface $propertyAccessor,
+        private readonly ManagerRegistry $registry,
+        private readonly PropertyAccessorInterface $propertyAccessor,
     ) {
     }
 

src/Util/ObjectAclManipulator.php

@@ -25,7 +25,7 @@
 
 final class ObjectAclManipulator extends BaseObjectAclManipulator
 {
-    public function __construct(private ManagerRegistry $registry)
+    public function __construct(private readonly ManagerRegistry $registry)
     {
     }
 

tests/App/Document/Author.php

@@ -28,7 +28,7 @@ class Author implements \Stringable
      * @var Collection<array-key, PhoneNumber>
      */
     #[ODM\EmbedMany(targetDocument: PhoneNumber::class)]
-    private Collection $phoneNumbers;
+    private readonly Collection $phoneNumbers;
 
     public function __construct(
         #[ODM\Id(type: Type::STRING, strategy: 'NONE')]

tests/App/Document/Book.php

@@ -25,7 +25,7 @@ class Book implements \Stringable
      * @var Collection<array-key, Category>
      */
     #[ODM\ReferenceMany(targetDocument: Category::class)]
-    private Collection $categories;
+    private readonly Collection $categories;
 
     public function __construct(
         #[ODM\Id(type: Type::STRING, strategy: 'NONE')]

tests/App/Document/Category.php

@@ -25,7 +25,7 @@ public function __construct(
         #[ODM\Field(type: Type::STRING)]
         private string $name = '',
         #[ODM\Field(type: Type::STRING)]
-        private string $type = '',
+        private readonly string $type = '',
     ) {
     }
 

tests/FieldDescription/FieldDescriptionTest.php

@@ -116,7 +116,7 @@ public function name(): string
         };
 
         $dummyChild = new class($dummyParent) {
-            public function __construct(private object $parent)
+            public function __construct(private readonly object $parent)
             {
             }
 

tests/Filter/CallbackFilterTest.php

@@ -57,7 +57,7 @@ public function testFilterMethodEmpty(): void
         $filter = new CallbackFilter();
         $filter->initialize('field_name', [
             'field_name' => self::DEFAULT_FIELD_NAME,
-            'callback' => [$this, 'customCallback'],
+            'callback' => $this->customCallback(...),
         ]);
 
         $filter->apply($builder, FilterData::fromArray([]));
@@ -72,7 +72,7 @@ public function testFilterMethodNotEmpty(): void
         $filter = new CallbackFilter();
         $filter->initialize('field_name', [
             'field_name' => self::DEFAULT_FIELD_NAME,
-            'callback' => [$this, 'customCallback'],
+            'callback' => $this->customCallback(...),
         ]);
 
         $filter->apply($builder, FilterData::fromArray(['value' => 'myValue']));

tests/Filter/ModelFilterTest.php

@@ -26,7 +26,7 @@
 
 class DocumentStub
 {
-    private ObjectId $id;
+    private readonly ObjectId $id;
 
     public function __construct()
     {

tests/Fixtures/Document/AssociatedDocument.php

@@ -21,7 +21,7 @@ class AssociatedDocument
 {
     public function __construct(
         #[ODM\Field(type: Type::INT)]
-        private int $plainField,
+        private readonly int $plainField,
         #[ODM\EmbedOne(targetDocument: EmbeddedDocument::class)]
         public EmbeddedDocument $embeddedDocument,
     ) {

tests/Fixtures/Document/ContainerDocument.php

@@ -24,7 +24,7 @@ class ContainerDocument
 
     public function __construct(
         #[ODM\ReferenceOne(targetDocument: AssociatedDocument::class)]
-        private AssociatedDocument $associatedDocument,
+        private readonly AssociatedDocument $associatedDocument,
         #[ODM\EmbedOne(targetDocument: EmbeddedDocument::class)]
         public EmbeddedDocument $embeddedDocument,
     ) {